Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEYCLOAK-7701 Refactor key providers to support additional algorithms #5309

Merged
merged 1 commit into from Jun 29, 2018

Conversation

stianst
Copy link
Contributor

@stianst stianst commented Jun 25, 2018

No description provided.

mposolda
mposolda previously approved these changes Jun 26, 2018
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stianst Nice!
Minor question: Shouldn't new java files have the licence header? I am not 100% sure it's needed, so I am approving and leaving to you to add if it's needed or not.

@stianst
Copy link
Contributor Author

stianst commented Jun 27, 2018

@mposolda added headers, can you reapprove please?

Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stianst re-approved. Thanks for adding headers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants