KEYCLOAK-18039: Optimise offline session load on startup #8012
Conversation
hmlnarik
added
kind/bug
| @@ -209,6 +217,28 @@ protected void initEmbedded() { | |||
| gcb.serialization().marshaller(new JBossUserMarshaller()); | |||
|
|
|||
| cacheManager = new DefaultCacheManager(gcb.build()); | |||
| if (useKeycloakTimeService) { | |||
| replaceComponent(cacheManager, TimeService.class, new EmbeddedTimeService() { | |||
There was a problem hiding this comment.
We already have KeycloakTestTimeService . How about moving it to model/infinispan to avoid using same code on multiple places?
Same probably applies to DefaultInfinispanConnectionProviderFactory.replaceComponent which is same code as InfinispanTestUtil.replaceComponent . This code uses infinispan internal stuff and it is a chance that during infinispan upgrade to newer version, there will be a need to change this code. So if we have same code with infinispan internals on two places in Keycloak codebase, it possibly increases the work for the infinispan upgrade in the future IMO.
Or just simplify the testsuite - maybe we can remove InfinispanTestUtil entirely and change TestingResourceProvider.setTestingInfinispanTimeService and TestingResourceProvider.revertTestingInfinispanTimeService to call DefaultInfinispanConnectionProviderFactory.setUseKeycloakTimeService or something like that? WDYT?
|
Model test failed is a known instability: https://issues.redhat.com/browse/KEYCLOAK-16999 |
There was a problem hiding this comment.
@hmlnarik Thanks for the update. Maybe one last thing: It looks class KeycloakTestTimeService can be entirely removed now as it is not used anymore? It seems to be used only in the javadoc to TestingResource.setTestingInfinispanTimeService() , but maybe that javadoc can be slightly changed to not reference it anymore?
Co-authored-by: Hynek Mlnarik <hmlnarik@redhat.com>
Updates and replaces #7902