[KEYCLOAK-17903] idp metadata describing one entity MUST have EntityDescriptor root element #8027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/KEYCLOAK-18049
Just removing the
EntitiesDescriptorType
because the SAML endpoint always adds only oneEntityDescriptorType
. We are following the spec now, besides this is already done this way in the SPMetadataDescriptor counterpart. Adding a check for this in theSAMLServletAdapterTest
for both SP and IDP endpoints and modifyingFixedHostnameTest
accordingly.@hmlnarik Take a look when you have some time and let me know if you see some improvement.