Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEYCLOAK-19364 : Add some vi_VN translations #8449

Closed
wants to merge 1 commit into from

Conversation

olivierboudet
Copy link
Contributor

KEYCLOAK-19364 : Add translations for locale vi. Only login and email messages are in this PR.

@stianst
Copy link
Contributor

stianst commented Oct 1, 2021

I would suggest changing to utf-8 encoding as it makes it easier to maintain and review the translations. This can be done with:

# encoding: utf-8
invalidPasswordMinLengthMessage=無効なパスワード: 最小{0}の長さが必要です。
invalidPasswordMinLowerCaseCharsMessage=無効なパスワード: 少なくとも{0}文字の小文字を含む必要があります。

@stianst
Copy link
Contributor

stianst commented Oct 1, 2021

We also need to find someone that is able to review the translation. Can you ask for volunteers on the developer mailing list (https://groups.google.com/forum/#!forum/keycloak-dev)?

@stianst stianst self-assigned this Oct 1, 2021
@stianst
Copy link
Contributor

stianst commented Nov 19, 2021

Closing due to lack of response

@stianst stianst closed this Nov 19, 2021
@olivierboudet
Copy link
Contributor Author

Hello @stianst, I have sent a message on the keycloak-dev list on 1st october : https://groups.google.com/u/2/g/keycloak-dev/c/_MmFVBnF6eo/m/klc6Pt_NAwAJ
Is this PR rejected by lack of reviewer ?

@stianst stianst reopened this Nov 19, 2021
@stianst
Copy link
Contributor

stianst commented Nov 19, 2021

Re-opened. Didn't notice that you'd pushed the changes for encoding (GH doesn't give any notifications when changes to the code are pushed, just new comments, etc.). Thanks for sending the mail to ml. Could you ask one more time, and if we don't get any help, I can try to review with help from Google translate. Or, perhaps you know any other native speakers that could review it?

@olivierboudet
Copy link
Contributor Author

OK thank you, I initially used "GH reactions" to not spam you with not very useful notifications :)
I have just sent a new message on the list. And sorry, the translation has been done by the only vitenamese speaker I know 😄

@olivierboudet
Copy link
Contributor Author

Hello @stianst apparently there is no Vietnamese speaker on the ML :)

@stianst
Copy link
Contributor

stianst commented Dec 15, 2021

That might suggest that there isn't anyone else interested in the Vietnamese translation. You could add the translations to a separate git repo and list it on the extensions page perhaps? That's probably the way we will go with all translations in the future as we plan to provide a better extension mechanism with a better way to discover and install them.

@olivierboudet
Copy link
Contributor Author

Ok thanks, so I close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants