New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEYCLOAK-19364 : Add some vi_VN translations #8449
Conversation
58fe861
to
7b6db73
Compare
I would suggest changing to utf-8 encoding as it makes it easier to maintain and review the translations. This can be done with: keycloak/themes/src/main/resources-community/theme/base/admin/messages/messages_ja.properties Lines 1 to 3 in 64717f6
|
We also need to find someone that is able to review the translation. Can you ask for volunteers on the developer mailing list (https://groups.google.com/forum/#!forum/keycloak-dev)? |
7b6db73
to
0331b94
Compare
Closing due to lack of response |
Hello @stianst, I have sent a message on the keycloak-dev list on 1st october : https://groups.google.com/u/2/g/keycloak-dev/c/_MmFVBnF6eo/m/klc6Pt_NAwAJ |
Re-opened. Didn't notice that you'd pushed the changes for encoding (GH doesn't give any notifications when changes to the code are pushed, just new comments, etc.). Thanks for sending the mail to ml. Could you ask one more time, and if we don't get any help, I can try to review with help from Google translate. Or, perhaps you know any other native speakers that could review it? |
OK thank you, I initially used "GH reactions" to not spam you with not very useful notifications :) |
Hello @stianst apparently there is no Vietnamese speaker on the ML :) |
That might suggest that there isn't anyone else interested in the Vietnamese translation. You could add the translations to a separate git repo and list it on the extensions page perhaps? That's probably the way we will go with all translations in the future as we plan to provide a better extension mechanism with a better way to discover and install them. |
Ok thanks, so I close this PR. |
KEYCLOAK-19364 : Add translations for locale
vi
. Only login and email messages are in this PR.