Add machine components #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezekg
force-pushed
the
feature/add-components
branch
2 times, most recently
from
0f7ec52
to
65ccdac
Compare
ezekg
commented
Sep 8, 2023
| if n > 1 { | ||
| params = validate{fingerprint: fingerprints[0], components: fingerprints[1:]} | ||
| } else { | ||
| params = validate{fingerprint: fingerprints[0]} |
There was a problem hiding this comment.
This is a breaking change, but likely one that will be low-impact. Looking at usage logs for Cloud, nobody actually uses more than 1 fingerprint. This was just an easy way to provide an optional argument.
There was a problem hiding this comment.
I say we go ahead with a v2.8.0 beta and see how it goes.
ezekg
force-pushed
the
feature/add-components
branch
3 times, most recently
from
c3cd4ff
to
fbc43e4
Compare
ezekg
force-pushed
the
feature/add-components
branch
5 times, most recently
from
d8713f0
to
ac23b79
Compare
ezekg
force-pushed
the
feature/add-components
branch
from
ac23b79
to
49fe62a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12.