Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: tss-esapi bindings #459

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Sep 26, 2022

Generate the tss-esapi bindings during compilation time. This will extend the ammount of supported architectures.

Signed-off-by: Alberto Planas aplanas@suse.com

Generate the tss-esapi bindings during compilation time.  This will
extend the ammount of supported architectures.

Signed-off-by: Alberto Planas <aplanas@suse.com>
@lkatalin
Copy link
Contributor

Looks like it wants libclang:

thread 'main' panicked at 'Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.so', 'libclang-*.so', 'libclang.so.*', 'libclang-*.so.*'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.59.2/src/lib.rs:2144:31
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@aplanas
Copy link
Contributor Author

aplanas commented Sep 27, 2022

Looks like it wants libclang:

Yes, as a build dependency. The feature bring bindgen, that uses clang to parse and generate the stubs. Checking keylime_rust.Dockerfile I can see that it mark clang-devel as a dependency, so that should be enough. Is the test env using a different set of dependencies?

@ansasaki
Copy link
Contributor

Looks like it wants libclang:

thread 'main' panicked at 'Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.so', 'libclang-*.so', 'libclang.so.*', 'libclang-*.so.*'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.59.2/src/lib.rs:2144:31
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I think we need to update the tests requirements to install clang on the machines before trying to build.

@aplanas Could you please open a PR to add the requirement in https://github.com/RedHat-SP-Security/keylime-tests/blob/main/setup/install_upstream_rust_keylime/main.fmf ?

@aplanas
Copy link
Contributor Author

aplanas commented Sep 27, 2022

@ansasaki
Copy link
Contributor

/packit retest-failed

@ansasaki ansasaki merged commit 2a65e76 into keylime:master Sep 27, 2022
@aplanas aplanas deleted the fix_tss_esapi_bindings branch October 26, 2022 06:24
aplanas added a commit to aplanas/rust-keylime that referenced this pull request Jan 17, 2023
Generate the tss-esapi bindings during compilation time.  This will
extend the ammount of supported architectures.

This is a regression done after the crate split, that was fixed before
in keylime#459.

Signed-off-by: Alberto Planas <aplanas@suse.com>
aplanas added a commit to aplanas/rust-keylime that referenced this pull request Jan 17, 2023
Generate the tss-esapi bindings during compilation time.  This will
extend the amount of supported architectures.

This is a regression done after the crate split, that was fixed before
in keylime#459.

Signed-off-by: Alberto Planas <aplanas@suse.com>
ansasaki pushed a commit to aplanas/rust-keylime that referenced this pull request Jan 19, 2023
Generate the tss-esapi bindings during compilation time.  This will
extend the amount of supported architectures.

This is a regression done after the crate split, that was fixed before
in keylime#459.

Signed-off-by: Alberto Planas <aplanas@suse.com>
ansasaki pushed a commit that referenced this pull request Jan 20, 2023
Generate the tss-esapi bindings during compilation time.  This will
extend the amount of supported architectures.

This is a regression done after the crate split, that was fixed before
in #459.

Signed-off-by: Alberto Planas <aplanas@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants