Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm/fedora: Fix metadata patch #568

Merged
merged 1 commit into from
Apr 21, 2023
Merged

rpm/fedora: Fix metadata patch #568

merged 1 commit into from
Apr 21, 2023

Conversation

ansasaki
Copy link
Contributor

With the changes in the Cargo.toml, the patch for the rpm also needs to
be fixed

Signed-off-by: Anderson Toshiyuki Sasaki ansasaki@redhat.com

With the changes in the Cargo.toml, the patch for the rpm also needs to
be fixed

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Copy link
Contributor

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. If CI agrees merge away :-)

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #568 (1a321dc) into master (ca0aad5) will not change coverage.
The diff coverage is n/a.

❗ Current head 1a321dc differs from pull request most recent head 0651af5. Consider uploading reports for the commit 0651af5 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 58.83% <ø> (ø)
upstream-unit-tests 58.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ansasaki
Copy link
Contributor Author

The build on Fedora 38 is expected to fail due to the missing rust-base64 package version 0.13. Note that without #565 the dependencies used for Fedora >= 38 are the system installed dependencies.

The tests on Fedora 38 are expected to fail. The issue is fixed by https://bodhi.fedoraproject.org/updates/FEDORA-2023-c907a05c30, which should reach stable tomorrow.

I'll drop the temporary commit and merge.

@ansasaki ansasaki merged commit 9982012 into keylime:master Apr 21, 2023
@ansasaki ansasaki deleted the fix_rpm branch April 21, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants