Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement creating a PR #60

Merged
merged 13 commits into from
Apr 27, 2020
Merged

feat: Implement creating a PR #60

merged 13 commits into from
Apr 27, 2020

Conversation

ermshiperete
Copy link
Collaborator

@ermshiperete ermshiperete commented Apr 24, 2020

This change allows to select a single keyboard repo in the frontend and create or update a PR for it.

Currently the single keyboard repo name is used as directory name in the keyboards repo. This should be based on the keyboardId (if set).

Implements #56, #57, #6, and #7.


This change is Reviewable

@ermshiperete ermshiperete added this to In Code Review in Frontend via automation Apr 24, 2020
@ermshiperete ermshiperete added this to In code review in Backend via automation Apr 24, 2020
@ermshiperete ermshiperete added the enhancement New feature or request label Apr 24, 2020
@ermshiperete ermshiperete added this to the P10S5 milestone Apr 24, 2020
@ermshiperete ermshiperete self-assigned this Apr 24, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert when merging c7ab62d into 3cf1dcf - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I have not run this locally, however.

@ermshiperete ermshiperete merged commit e737bf0 into master Apr 27, 2020
Frontend automation moved this from In Code Review to Done Apr 27, 2020
Backend automation moved this from In code review to Done Apr 27, 2020
@ermshiperete ermshiperete deleted the feat/pull-request branch April 27, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Backend
  
Done
Frontend
  
Done
2 participants