Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rollback incorrect update to constants #91

Merged
merged 1 commit into from Dec 1, 2019
Merged

chore: rollback incorrect update to constants #91

merged 1 commit into from Dec 1, 2019

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 30, 2019 •
edited

This was a misdiagnosis of an unrelated issue
as shown in keymanapp/keyman#2398.

Rolling back change applied in #89.

@mcdurdin
chore: rollback incorrect update to constants
19872c2 
This was a misdiagnosis of an unrelated issue
as shown in keymanapp/keyman#2398.
@mcdurdin mcdurdin added the bug Something isn't working label Nov 30, 2019
@mcdurdin mcdurdin added this to the P8S5 milestone Nov 30, 2019
eddieantonio
eddieantonio approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@eddieantonio eddieantonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I'm glad this works! 😅

@mcdurdin mcdurdin merged commit e2bebdf into master Dec 1, 2019
@mcdurdin mcdurdin deleted the chore/rollback-named-constant-smp-note branch December 1, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddieantonio eddieantonio eddieantonio approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
P8S5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcdurdin @eddieantonio