Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] nul, smp characters, and legacy apps do not work correctly #2398

Closed
mcdurdin opened this issue Nov 30, 2019 · 0 comments 路 Fixed by #2399
Closed

[Windows] nul, smp characters, and legacy apps do not work correctly #2398

mcdurdin opened this issue Nov 30, 2019 · 0 comments 路 Fixed by #2399
Labels
bug windows/
Milestone
P8S5

Comments

@mcdurdin
Copy link
Member

Describe the bug
A keyboard that uses nul to delete context, together with SMP characters in the context, breaks when used in legacy app in Windows.

With the following code, pressing 123 should result in 馃榾馃槓 but instead shows 馃榾3, but only in legacy apps on Windows. Other situations work fine. This indicates most likely an engine bug, not core nor compiler.

Replaces #2391. Originally reported under #2391 but that issue was a misdiagnosis.

+ "1" > U+1F600 U+1F601
U+1F601 + "2" > nul
U+1F600 + '3' > context U+1F610

Keyman Desktop:

  • OS: Windows 10
  • Keyman version: 12.0
  • Target Application: non-TSF apps
@mcdurdin mcdurdin added this to the P8S5 milestone Nov 30, 2019
@mcdurdin mcdurdin mentioned this issue Nov 30, 2019
Closed
mcdurdin added a commit to keymanapp/help.keyman.com that referenced this issue Nov 30, 2019
@mcdurdin
chore: rollback incorrect update to constants
19872c2 
This was a misdiagnosis of an unrelated issue
as shown in keymanapp/keyman#2398.
@mcdurdin mcdurdin mentioned this issue Nov 30, 2019
Merged
mcdurdin added a commit that referenced this issue Dec 1, 2019
@mcdurdin
fix(windows): smp characters could break context
fa3e4ae 
Fixes #2398.
@mcdurdin mcdurdin mentioned this issue Dec 1, 2019
Merged
mcdurdin added a commit that referenced this issue Dec 1, 2019
@mcdurdin
fix(windows): smp characters could break context
52a78d6 
Fixes #2398.
@mcdurdin mcdurdin mentioned this issue Dec 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug windows/
Milestone
P8S5
Development

Successfully merging a pull request may close this issue.

fix(windows): smp characters could break context keymanapp/keyman
1 participant
@mcdurdin