Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[font_abys] Update Abyssinica SIL font #2263

Merged
merged 1 commit into from Jun 25, 2023

Conversation

LornaSIL
Copy link
Contributor

No description provided.

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidLRowe DavidLRowe merged commit eb3ee3b into keymanapp:master Jun 25, 2023
2 checks passed
@LornaSIL LornaSIL deleted the font_abys branch June 26, 2023 13:35
@mcdurdin
Copy link
Member

mcdurdin commented Jul 7, 2023

Note that this will not be released in existing versions of the keyboards -- they'd need a version bump.

@LornaSIL
Copy link
Contributor Author

LornaSIL commented Jul 7, 2023

Note that this will not be released in existing versions of the keyboards -- they'd need a version bump.

Yes, and that's fine. It wasn't a big change, but it enabled @dyacob to produce the Alternate Typetuned fonts he wanted to add to gff_ethiopic which was just approved.

@darcywong00
Copy link
Contributor

darcywong00 commented Jul 7, 2023

@LornaSIL
Copy link
Contributor Author

LornaSIL commented Jul 7, 2023

Technically, it should be updated, but the fix to the font only affects the ability to use it on typetunerweb, so I didn't bother this time. I just wanted the versions in the repo to match the new "alternate 1" and "alternate 2" fonts that @dyacob was adding.

@dyacob
Copy link
Contributor

dyacob commented Jul 7, 2023

I fully concur with @LornaSIL . The update to the font was very minor and will not impact any of the GFF keyboards or documentation, it was sort of a metadata update that allowed 2 derivative fonts to be generated correctly.

So it's nothing critical and no rush to make the update that @darcywong00 has asked about, the update can be made whenever there is a convenient opportunity.

@mcdurdin
Copy link
Member

mcdurdin commented Jul 8, 2023

Thanks @LornaSIL, that's helpful and means I won't be scratching our heads later re font versions 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants