Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runeboard Version 2 Update #2334

Merged
merged 13 commits into from Aug 14, 2023
Merged

Runeboard Version 2 Update #2334

merged 13 commits into from Aug 14, 2023

Conversation

Runeboard
Copy link
Contributor

For now, this is only the Runeboard update. (I'll hold the Elfdalian keyboard til this is done.)

I think everything should be in order now except that I can't work out how to create the images for the Tablet layout. Consequently, I've simply not included them and left the related part out of the code.

Images are missing for the tablet layout because I can't figure out how to create them.
The only font included with this version will be Catrinity.
The only font included with this version will be Catrinity.
The only font included with this version will be Catrinity.
@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@LornaSIL LornaSIL added this to In progress in Keyboards Aug 10, 2023
@Runeboard
Copy link
Contributor Author

What exactly is the conflict here? The font has been changed. The old file can simply be overwritten.

@LornaSIL
Copy link
Contributor

The conflict is probably because we updated ALL (or almost all) of the keyboard_info files last week. Can you merge/master into your PR? Then I will do a check. Last week we were doing a lot of metadata fixing of keyboards getting ready for the next big version of Keyman, and I didn't have time to look at your PR. Sorry.

I just realized I could modify it. I'll try and see if it fixes the conflict.
@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

`non` is the correct tag as the default script is `Runr` so it's not needed in the tagset.
@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is still experimental, I didn't check your changes carefully, but it does build.

@LornaSIL LornaSIL merged commit 57447a8 into keymanapp:master Aug 14, 2023
2 checks passed
Keyboards automation moved this from In progress to Done Aug 14, 2023
@Runeboard
Copy link
Contributor Author

Thanks LornaSIL. I'm not in any hurry so no worries about the time. Thanks for informing me of the other update. As you seem to have accepted this pull request, I take it there's nothing more I need to do now. Thanks again for all your help.

@LornaSIL
Copy link
Contributor

As you seem to have accepted this pull request, I take it there's nothing more I need to do now.

Correct. I was able to fix the merge conflict. Please make sure to pick up the latest files before doing any modifications in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Keyboards
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants