Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fv southern tutchone #2350

Merged

Conversation

HopsAndHops
Copy link
Contributor

@HopsAndHops HopsAndHops commented Aug 24, 2023

  • Updated to single codepoint outputs where possible
  • Updated documentation
  • Centered keyboard
  • Removed duplicate punctuation

Approved by @caforbes

@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

'Ų̈́' + any(MBackspace) > 'Ų̈'
'Ų̈̀' + any(MBackspace) > 'Ų̈'


store(&LAYOUTFILE) 'fv_southern_tutchone.keyboard_info'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixup &layoutfile reference in fv_southern_tutchone.kmn

Regarding my other comment on the pull request about renaming files

Suggested change
store(&LAYOUTFILE) 'fv_southern_tutchone.keyboard_info'
store(&LAYOUTFILE) 'fv_southern_tutchone.keyman-touch-layout'

@darcywong00
Copy link
Contributor

Thank you for the keyboard submission!

There's some cleanup of filenames as follows:

fv_southern_tutchone:
a. delete source/fv_southern_tutchone.keyman-touch-layout
b. rename source/fv_southern_tutchone.keyboard_info to source/fv_southern_tutchone.keyman-touch-layout
c. fixup &layoutfile reference in fv_southern_tutchone.kmn
d. ask FV team to verify the touch layout is correct.

@HopsAndHops
Copy link
Contributor Author

Thanks, Darcy! Made the requested changes. The keyboard was approved by @caforbes

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LornaSIL LornaSIL merged commit 24e4f3f into keymanapp:master Aug 25, 2023
2 checks passed
@HopsAndHops HopsAndHops deleted the fv_southern_tutchone branch August 25, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants