Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newa_traditional_extended] New keyboard #2421

Merged
merged 3 commits into from Oct 27, 2023
Merged

[newa_traditional_extended] New keyboard #2421

merged 3 commits into from Oct 27, 2023

Conversation

SvarnimN
Copy link
Contributor

Newa Traditional Extended Layout is based on Newa Traditional Layout. Newa Traditional Extended layout is more accessible and easy to use. It also includes the most commonly used conjuncts and special characters.

@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@LornaSIL LornaSIL added this to In progress in Keyboards Oct 27, 2023
@LornaSIL
Copy link
Contributor

Nice Pull Request!

Two things. Could you delete the .gitignore file? from the PR?

  • The other thing isn't required, but I would recommend you add the keyboards\release\shared\fonts\noto\Newa\NotoSansNew-Regular.ttf font to the .kps files. Then, for the Keyboards tab you can select the font for both "Keyboard font" and "Display font". (I see the newa_traditional keyboard doesn't do this, but we should probably add it!) Doing this would make it easier for the users of the keyboard.

@LornaSIL LornaSIL moved this from In progress to Awaiting approval in Keyboards Oct 27, 2023
@LornaSIL LornaSIL changed the title add Newa Traditional Extended Layout [newa_traditional_extended] New keyboard Oct 27, 2023
@SvarnimN
Copy link
Contributor Author

@LornaSIL .gitignore file has been removed and Noto Sans Newa Regular font has been added to the kps file.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit 679da0f into keymanapp:master Oct 27, 2023
2 checks passed
Keyboards automation moved this from Awaiting approval to Done Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Keyboards
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants