Changed order of mobile layers to unscramble display on help pages #2439
Conversation
|
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
|
@HopsAndHops is this still in draft or do you need it reviewed and approved? |
|
@LornaSIL still draft for now! Thanks for checking in :) |
|
The system did not notify me that you had changed the status to "ready for review" so I guess in the future it would be good to tag one of us. I'll check it. |
|
@LornaSIL Thanks for letting me know! I'll tag you going forward :) |
I should have said JUST when you change the status or label. We do get notified when you make a change in the PR like changed files. |
|
@HopsAndHops Because I approved #2458 there is now a merge conflict because this PR also makes changes to fv_nuxalk. I think you'll need to resolve the conflicts before I can approve it. |
|
Would it work to remove fv_nuxalk changes from this PR? Then, if necessary, you could make a new PR with just those fv_nuxalk changes. (I'm not sure if that addresses the problem, but might be easy enough to try.) |
|
Whoops my bad, totally forgot that Nuxalk was included in this batch. I'll resolve those conflicts shortly |
|
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
|
No dice, I'll undo the changes on the changes to Nuxalk and make another PR with only those changes |
|
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
Changed order of mobile layers to unscramble display on help pages on all FV keyboards affected.
Approved by @caforbes