Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFF Sheek Bakrii Saphaloo Qubee Keyboard v1.0.1 #2483

Merged
merged 4 commits into from Dec 5, 2023

Conversation

dyacob
Copy link
Contributor

@dyacob dyacob commented Dec 5, 2023

This PR fixes #2482 .

The welcome.htm and gff_sbs.php files both have the needed link corrections. The correction was tested successfully on the welcome.htm page.

@DavidLRowe's earlier suggestion for the README.md file have also been applied. Thanks @DavidLRowe !

@keyman-server
Copy link
Collaborator

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

@LornaSIL
Copy link
Contributor

LornaSIL commented Dec 5, 2023

Right now the version is 1.0.1 in several places (HISTORY.md and .kps), but in the kmn and .kpj it says 1.0.2. Can you set the version you want...probably the .kmn needs changing.

@dyacob
Copy link
Contributor Author

dyacob commented Dec 5, 2023

@LornaSIL got it now, the result of another experiment that led to a bug report. Thanks.

change to 1.0.1
Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit c3d0a43 into keymanapp:master Dec 5, 2023
2 checks passed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Athrinka' should be 'Athinkra'.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Athrinka' should be 'Athinkra'.

@LornaSIL
Copy link
Contributor

LornaSIL commented Dec 6, 2023

Thanks. I created an issue so we can track it there since this PR is closed: #2490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(gff_sbs): missing pdf in documentation
4 participants