Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[itrans_roman] add a rule to output U+2019 when type U+0027 (') twice #2546

Merged
merged 9 commits into from Feb 14, 2024
Merged

[itrans_roman] add a rule to output U+2019 when type U+0027 (') twice #2546

merged 9 commits into from Feb 14, 2024

Conversation

Meng-Heng
Copy link
Contributor

The information that requested for this change - #2539

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@LornaSIL LornaSIL added this to In progress in Keyboards Feb 13, 2024
@LornaSIL
Update LICENSE.md
c7c0b1a 
Add space between copyright sign and text.
@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@LornaSIL
Update itrans_roman.kpj
ae88dbf 
Add space between copyright and year.
@LornaSIL
Update itrans_roman.kmn
f9032df 
Remove copyright years so they don't have to keep being updated in kmn. LICENSE.md is the main one needing the year.
@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

LornaSIL
LornaSIL approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@LornaSIL LornaSIL merged commit 33c3216 into keymanapp:master Feb 14, 2024
2 checks passed
Keyboards automation moved this from In progress to Done Feb 14, 2024
@LornaSIL LornaSIL mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LornaSIL LornaSIL LornaSIL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Keyboards
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Meng-Heng @keyman-server @LornaSIL