Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bj_cree_east] Fix bug related to previous change to NFD #2564

Merged
merged 4 commits into from Feb 22, 2024

Conversation

LornaSIL
Copy link
Contributor

This was the report

this is what she types: waau, twaau, chwaau, swaau
this is what she gets: ᐙᐅ, ᑣᐅ, ᒞᐅ, ᔂᐅ
She does NOT want that… and she does not want this either: ᐙᐧ, ᑣᐧ, ᒞᐧ, ᔂᐧ

But this is what she wants: ᐙᐤ, ᑣᐤ, ᒞᐤ, ᔂᐤ

(the final u typed should be a U+1424, not a U+1405 or U+1427)

I discovered the same issue arose with wiiu and wuuu. So, I wrote rules to fix that issue. It's related to when I updated the keyboard to support NFC by default and NFD with an option key.

I have asked if the problem exists elsewhere.

@LornaSIL LornaSIL added this to In progress in Keyboards Feb 20, 2024
@LornaSIL
Copy link
Contributor Author

I guess we have to decide whether to put backspace rules in to handle expected behavior. This would take more time.

@LornaSIL
Copy link
Contributor Author

I realized the same bug existed in the bj_oji_cree keyboard as well since I updated them to use NFC at the same time.

@LornaSIL LornaSIL moved this from In progress to Awaiting approval in Keyboards Feb 21, 2024
@DavidLRowe
Copy link
Contributor

I see that bj_cree_east.kps has

<Version>9.1.1</Version>

whereas the updated keyboard version is 9.2.0. I'm assuming the <FollowKeyboardVersion/> will override what's in the .kps file with the 9.2.0 from the .kmn file. If not, you can dismiss my review and change it.

Copy link
Contributor

@DavidLRowe DavidLRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (see comment)

@LornaSIL
Copy link
Contributor Author

Technically it's supposed to be fine, so I will go ahead and merge and double-check :)

@LornaSIL LornaSIL merged commit bb1964d into keymanapp:master Feb 22, 2024
2 checks passed
Keyboards automation moved this from Awaiting approval to Done Feb 22, 2024
@LornaSIL LornaSIL deleted the bj_cree_east branch February 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Keyboards
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants