Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sil_ipa] Add subscript numerals to _ rota #2587

Merged
merged 3 commits into from Mar 19, 2024
Merged

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Mar 4, 2024

Fixes #2401

This adds subscript numerals to the underscore _ rota

e.g.

Character Sequence
3_
3__
3___
3_____
3______
3_______

(update)
When options are set to 'before', the sequence

Character Sequence
_3

Rota still uses "_" after.

@LornaSIL LornaSIL added this to Awaiting approval in Keyboards Mar 4, 2024
@LornaSIL
Copy link
Contributor

LornaSIL commented Mar 4, 2024

So, it looks like you intentionally didn't try to make it work differently when the options are changed.

@darcywong00
Copy link
Contributor Author

So, it looks like you intentionally didn't try to make it work differently when the options are changed.

At first I was going to follow the 'before' and '' options, but then it seemed odd for a rota.
I can try going back to options

@darcywong00
Copy link
Contributor Author

OK, I've updated the options rules to convert subscript numerals with U+0320 since underscore _ automatically converts to combining minus sign below U+0320.

For 'before' options, _3 outputs ; and type 3_ to get to the rota .

For 'after' options, 3_ outputs , ₃_ gets to the rota

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want the sil_ipa.php file in the welcome folder. The one in the help is the correct location.

@darcywong00
Copy link
Contributor Author

I don't think we want the sil_ipa.php file in the welcome folder. The one in the help is the correct location.

Good catch. I updated the help/ file and removed the extra one.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit a7c7baf into master Mar 19, 2024
2 checks passed
Keyboards automation moved this from Awaiting approval to Done Mar 19, 2024
@LornaSIL LornaSIL deleted the sil_ipa/subscript-numerals branch March 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Keyboards
  
Done
Development

Successfully merging this pull request may close these issues.

[sil_ipa] request to add subscript numerals
2 participants