Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fv_secwepemctsin #2601

Merged

Conversation

xyzhelen
Copy link
Contributor

General - updated underlying unicode for vowels with acute accent, updated help documentation, updated keymap image; Mobile- fixed spacing; Desktop - removed the 7 mapping from the slash key

updated underlying unicode for vowels with acute accent, updated help documentation and keymap image; mobile- fixed spacing; desktop - removed the 7 from the slash key
@xyzhelen
Copy link
Contributor Author

@caforbes

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@DavidLRowe
Copy link
Contributor

Assume we're waiting for approval from @caforbes

@caforbes
Copy link
Contributor

Looks good to me, I already gave it a thumbs up! No need to wait on me in future, FYI.

@LornaSIL LornaSIL added this to In progress in Keyboards Mar 18, 2024
@LornaSIL
Copy link
Contributor

@xyzhelen keyboard_info file will need the language tag changed to match the change you made in .kps.

fixed language tag in info file
@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit a76859f into keymanapp:master Mar 21, 2024
2 checks passed
Keyboards automation moved this from In progress to Done Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Keyboards
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants