Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kreative_superipa] New keyboard submission #2620

Merged
merged 3 commits into from Mar 22, 2024

Conversation

RebeccaRGB
Copy link

No description provided.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@LornaSIL LornaSIL added this to Awaiting approval in Keyboards Mar 21, 2024
@LornaSIL LornaSIL moved this from Awaiting approval to In progress in Keyboards Mar 21, 2024
@LornaSIL
Copy link
Contributor

It looks pretty good.

For our IPA keyboards we have used und-Latin for the .kps and und-fonipa in keyboard_info. I think there's a good reason, but I can't remember why, maybe because of something in how Windows handles language tagging. Even that isn't ideal. Is that still our recommendation @mcdurdin ?

I will again make the comment that you have a tablet and phone layout that look the same. If that is true, it would be easier to maintain just one and delete the other one.

Otherwise it looks good.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@mcdurdin
Copy link
Member

I think there's a good reason, but I can't remember why, maybe because of something in how Windows handles language tagging.

There's a bug in .NET framework relating to und language tag which causes any .NET application to instantly crash when that language is selected: keymanapp/keyman#10727. Microsoft are aware of the issue but I am not sure how quickly it will be addressed. We may try and submit a pull request to them at some point, but there are challenges with doing that too.

und-fonipa won't even install in Windows: keymanapp/keyman#10754.

Is that still our recommendation @mcdurdin ?

So yes, the split setup is still our recommendation, I think, but beware of the above crash scenario. The alternative tags seem generally worse, perhaps mul-Latn is borderline better, although I haven't tested that thoroughly.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly.

@LornaSIL LornaSIL moved this from In progress to Awaiting approval in Keyboards Mar 22, 2024
Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit c0f1ebe into keymanapp:master Mar 22, 2024
2 checks passed
Keyboards automation moved this from Awaiting approval to Done Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Keyboards
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants