Update taigi_telex.kmn #2761
Closed
Update taigi_telex.kmn #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
|
Thanks for these Pull Requests. You did put the .kmn files in the correct location, so that is good! You had two pull requests for the same keyboard so you should close one of the However, there is more to updating a keyboard than just the rules in a .kmn file, so my comments here relate to both of your keyboards. When a keyboard is updated you must increase the version number. In addition, the Since you have a touch layout, you may wish to update that as well. The default layer has your accented vowels on longpress keys. Those uppercase ones are not yet available on the shift layer. I recommend you add the uppercase accented characters to the shifted longpress keys.. For these keyboards, since they were created this year, you do not need to update |
|
Thank you.
I also want to change my touch-layout. I have created my new keyman-touch-layout files. But I found I can not apply it on my phone. I have checked the file. I did add the new features in But I can not use long-press to select letters. Can you explain why and help me to solve this issue? At least I should test this new touch layout on my phone at first then upload it.
Sent with [Proton Mail](https://proton.me/) secure email.
…On Friday, 17 May 2024 at 3:48 PM, Lorna Evans ***@***.***> wrote:
Thanks for these Pull Requests. You did put the .kmn files in the correct location, so that is good! You had two pull requests for the same keyboard so you should close one of the taigi_telex pull requests.
However, there is more to updating a keyboard than just the rules in a .kmn file, so my comments here relate to both of your keyboards.
When a keyboard is updated you must increase the version number.
Currently, you have this header statement:
store(&KEYBOARDVERSION) '1.0'
If the change is great, you could increase the version to 1.1. If the change is small, you could increase the version to 1.0.1:
store(&KEYBOARDVERSION) '1.0.1'
In addition, the HISTORY.md file must be updated to track what changed in this version. So, for this keyboard, you could have:
Taigi_telex Change History
====================
1.0.1 (2024-05-17)
----------------
* Added rules to support typing uppercase vowels
1.0 (2024-03-24)
----------------
* Created by cathaylab
Since you have a touch layout, you may wish to update that as well. The default layer has your accented vowels on longpress keys. Those uppercase ones are not yet available on the shift layer. I recommend you add the uppercase accented characters to the shifted longpress keys..
For these keyboards, since they were created this year, you do not need to update LICENSE.md, but next year if you update the keyboard you will need to change the copyright dates to © 2024-2025 cathaylab
—
Reply to this email directly, [view it on GitHub](#2761 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRUO57XGKJGEJJEABW3ZCYKFTAVCNFSM6AAAAABH3TXQZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXG43TGNZQHE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
At the Nguphing keyboard I have added 3 selections in one key. In the updates I added 5 selections on one key. Is it too much? Maybe I should change them to flick to solve this issue
Sent with [Proton Mail](https://proton.me/) secure email.
…On Saturday, 18 May 2024 at 7:54 AM, wongwanho ***@***.***> wrote:
Thank you.
I also want to change my touch-layout. I have created my new keyman-touch-layout files. But I found I can not apply it on my phone. I have checked the file. I did add the new features in But I can not use long-press to select letters. Can you explain why and help me to solve this issue? At least I should test this new touch layout on my phone at first then upload it.
Sent with [Proton Mail](https://proton.me/) secure email.
On Friday, 17 May 2024 at 3:48 PM, Lorna Evans ***@***.***> wrote:
> Thanks for these Pull Requests. You did put the .kmn files in the correct location, so that is good! You had two pull requests for the same keyboard so you should close one of the taigi_telex pull requests.
>
> However, there is more to updating a keyboard than just the rules in a .kmn file, so my comments here relate to both of your keyboards.
>
> When a keyboard is updated you must increase the version number.
> Currently, you have this header statement:
> store(&KEYBOARDVERSION) '1.0'
> If the change is great, you could increase the version to 1.1. If the change is small, you could increase the version to 1.0.1:
> store(&KEYBOARDVERSION) '1.0.1'
>
> In addition, the HISTORY.md file must be updated to track what changed in this version. So, for this keyboard, you could have:
>
> Taigi_telex Change History
> ====================
>
> 1.0.1 (2024-05-17)
> ----------------
> * Added rules to support typing uppercase vowels
>
> 1.0 (2024-03-24)
> ----------------
> * Created by cathaylab
>
> Since you have a touch layout, you may wish to update that as well. The default layer has your accented vowels on longpress keys. Those uppercase ones are not yet available on the shift layer. I recommend you add the uppercase accented characters to the shifted longpress keys..
>
> For these keyboards, since they were created this year, you do not need to update LICENSE.md, but next year if you update the keyboard you will need to change the copyright dates to © 2024-2025 cathaylab
>
> —
> Reply to this email directly, [view it on GitHub](#2761 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRUO57XGKJGEJJEABW3ZCYKFTAVCNFSM6AAAAABH3TXQZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXG43TGNZQHE).
> You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Each keyboard needs all the changes in one pull request. You are still submitting separate pull requests for each file, and we cannot accept those. The changes for each keyboard must all be done in one pull request. |
|
How can I do all one changes in one request? Should I download the file at first. Then I edit them in my computer, then I re-upload the file?
Thank you.
Ivan
Sent with [Proton Mail](https://proton.me/) secure email.
…On Tuesday, 21 May 2024 at 2:50 PM, Lorna Evans ***@***.***> wrote:
Each keyboard needs all the changes in one pull request. You are still submitting separate pull requests for each file, and we cannot accept those. The changes for each keyboard must all be done in one pull request.
—
Reply to this email directly, [view it on GitHub](#2761 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRVOVJRKOOARTJL5OATZDNGLZAVCNFSM6AAAAABH3TXQZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGY4DMOJZGE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Have you received my new keyboard cantonese telex request?
Sent with [Proton Mail](https://proton.me/) secure email.
…On Tuesday, 21 May 2024 at 2:50 PM, Lorna Evans ***@***.***> wrote:
Each keyboard needs all the changes in one pull request. You are still submitting separate pull requests for each file, and we cannot accept those. The changes for each keyboard must all be done in one pull request.
—
Reply to this email directly, [view it on GitHub](#2761 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRVOVJRKOOARTJL5OATZDNGLZAVCNFSM6AAAAABH3TXQZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGY4DMOJZGE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Replaced by #2805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add a series of new rules in the Taigi Telex