Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hieroglyphic] migrated to github #322

Merged
merged 12 commits into from
Jun 14, 2018
Merged

Conversation

andjc
Copy link
Contributor

@andjc andjc commented Jun 4, 2018

No description provided.

@DavidLRowe DavidLRowe added this to In progress in Keyboards Jun 4, 2018
@LornaSIL
Copy link
Contributor

LornaSIL commented Jun 4, 2018

  • In welcome.htm
    • Change use the Keyman Font Helper. to use the Keyman Desktop Font Helper. and remove the link. (also change in help file)
    • the link at the bottom should be changed to http://jsesh.qenherkhopeshef.org/ (also needs changing the help file)
  • help file
    • bullets at bottom don't seem to be correct.

I tested many of the keystrokes and they seem to work. Metadata seems fine. BCP47 is fine. So, with updating the above, I think it's ready.

@LornaSIL
Copy link
Contributor

LornaSIL commented Jun 5, 2018

Fixes #225

@andjc
Copy link
Contributor Author

andjc commented Jun 6, 2018

@LornaSIL, you wrote that in the help file teh bullets at bottom don't seem to be correct. Could you clarify? The markup appears to be identical in welcome and help files. There is an ordered list, no unordered list, so am uncertain what you mean by the bullets appear incorrect.

@LornaSIL
Copy link
Contributor

LornaSIL commented Jun 6, 2018

The bullets look like this in welcome.htm:
image

and like this in the help file:
image

I would suggest removing all the bulleted list info in the help file:
image

But, that's the way the "legacy" keyboard help file was so it's not a big deal. Let me know your preference.

@andjc
Copy link
Contributor Author

andjc commented Jun 6, 2018

@lorna, will remove, that will be easiest. But it's odd, definitely an ordered list in the markup, not an unordered list. Even if there was some problem in the code at some point that. But would like to understand where the bullets are coming from, and why. Its odd.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LornaSIL LornaSIL merged commit 9151fc5 into keymanapp:master Jun 14, 2018
Keyboards automation moved this from In progress to Done Jun 14, 2018
@LornaSIL
Copy link
Contributor

Should be available here soon: https://keyman.com/keyboards/hieroglyphic

@andjc andjc deleted the hieroglyphic branch July 5, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Keyboards
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants