Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move landing pages to keyboards/h #177

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Sep 22, 2020

Fixes #175. All keyboard landing pages are now under /keyboards/h/ and the root paths redirect accordingly.

This should allow the embedded search dialogs to treat these links as internal to the search and not pop them into an external browser.

Fixes #175. All keyboard landing pages are now /keyboards/h/ and
the root paths redirect accordingly.
@mcdurdin mcdurdin added this to the P10S16 milestone Sep 22, 2020
@mcdurdin mcdurdin added the chore label Sep 22, 2020
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from fix/search-cleanup-and-refactor to staging September 22, 2020 02:56
@mcdurdin mcdurdin merged commit 98fb821 into staging Sep 22, 2020
@mcdurdin mcdurdin deleted the chore/move-landing-pages-to-keyboards-h branch September 22, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants