Android modifier chirality #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow-on to #300 for adding chirality modifiers to KMEA. Add support for L/R Ctrl, Alt, caps lock, num lock, and scroll lock for external keyboard - temporarily adding test chriality.js keyboard
-Update KMEA to copy keyman-engine.aar to Tests/ for future test apps to consume.
Refactor KMManager.getActiveKeyboard() Move modifierCodes to separate class Clean up .gitignore
Per review comments * Rename chirality to keyboardHarness * Change namespace to com.keyman.android.tests.keyboardHarness * Add readme.md for info
* Document shift states and lock states in kmembedded.js, and standardize `lstates` parameter name * Leave getActiveKeyboard() refactor as a TODO
Addresses PR comment of not using a timeout that assumes keyboard is ready in preference of KMW event (keyboard loaded or changed) This is still wip
- Update In-app keyboard `isChiral` property when the OSK is shown - Update System keyboard `isChiral` property on the event onKeyboardChanged() This implementation comes out of the complication when in-app or system keyboard is changed, KMManager.setKeyboard is changing both keyboards
Updates to new onKeyboardChanged signature Also incorporated external keyboard support to KMSample2
Attempt to move to JS handler in KMManager
Cleanup code after moving chirality test to KMW event handler
Revert to original onKeyboardChanged() signature
Fix onKeyboardChanged signature
Remove chirality test keyboard from main kmapro app Fix KMSample2 compilation
7 tasks
mcdurdin
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-on to #300 for adding chirality modifiers to KMEA for external hardware keyboards.
Refer to #308 for initial PR during development.
Added: