Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android modifier chirality #341

Merged
merged 19 commits into from
Oct 4, 2017
Merged

Android modifier chirality #341

merged 19 commits into from
Oct 4, 2017

Commits on Oct 4, 2017

  1. Start adding chirality modifiers to KMEA 

    This is follow-on to #300 for adding chirality modifiers to KMEA.

Add support for L/R Ctrl, Alt, caps lock, num lock, and scroll lock for external keyboard

- temporarily adding test chriality.js keyboard
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    f9066a5 View commit details
    Browse the repository at this point in the history

  2. Add hooks for KMManager to check if keyboard is chiral

    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    df23e41 View commit details
    Browse the repository at this point in the history

  3. Move test chirality keyboard to new Tests/Chirality project 

    -Update KMEA to copy keyman-engine.aar to Tests/ for future test apps to consume.
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    3a0ee92 View commit details
    Browse the repository at this point in the history

  4. Start addressing review comments 

    Refactor KMManager.getActiveKeyboard()
Move modifierCodes to separate class
Clean up .gitignore
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    cd59fe4 View commit details
    Browse the repository at this point in the history

  5. Change chirality test app to keyboardHarness 

    Per review comments
* Rename chirality to keyboardHarness
* Change namespace to com.keyman.android.tests.keyboardHarness
* Add readme.md for info
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    353f090 View commit details
    Browse the repository at this point in the history

  6. Document bitmasks and undo getActiveKeyboard refactor 

    * Document shift states and lock states in kmembedded.js, and standardize `lstates` parameter name
* Leave getActiveKeyboard() refactor as a TODO
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    f9f3dc7 View commit details
    Browse the repository at this point in the history

  7. Refactor JS call of setIsChiral() to onKeyboardChanged event 

    Addresses PR comment of not using a timeout that assumes keyboard is ready in preference of KMW event (keyboard loaded or changed)

This is still wip
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    32bb4c6 View commit details
    Browse the repository at this point in the history

  8. Update isChiral on keyboard shown / changed 

    - Update In-app keyboard `isChiral` property when the OSK is shown
- Update System keyboard `isChiral` property on the event onKeyboardChanged()

This implementation comes out of the complication when in-app or system keyboard is changed, KMManager.setKeyboard is changing both keyboards
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    e2a8b76 View commit details
    Browse the repository at this point in the history

  9. Update Samples and Tests projects for handler API change 

    Updates to new onKeyboardChanged signature

Also incorporated external keyboard support to KMSample2
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    d66f52b View commit details
    Browse the repository at this point in the history

  10. Remove test chirality keyboard (again) from kmapro

    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    c8e54b9 View commit details
    Browse the repository at this point in the history

  11. Move chirality checks to KMEA 

    Attempt to move to JS handler in KMManager
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    e507462 View commit details
    Browse the repository at this point in the history

  12. Cleanup after attaching to KMW event 

    Cleanup code after moving chirality test to KMW event handler
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    aac2368 View commit details
    Browse the repository at this point in the history

  13. Cleanup sample projects 

    Revert to original onKeyboardChanged() signature
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    bc208fb View commit details
    Browse the repository at this point in the history

  14. Clean up TestHarness 

    Fix onKeyboardChanged signature
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    3a30d23 View commit details
    Browse the repository at this point in the history

  15. Clarify setIsChiral parameter

    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    adee729 View commit details
    Browse the repository at this point in the history

  16. Update calls to kmw.addEventLIstener

    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    ced4102 View commit details
    Browse the repository at this point in the history

  17. Tweaked keyboard.html a bit.

    @jahorton @darcywong00
    jahorton authored and darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    086e7c5 View commit details
    Browse the repository at this point in the history

  18. setIsChiral() is now operational.

    @jahorton @darcywong00
    jahorton authored and darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    16048e5 View commit details
    Browse the repository at this point in the history

  19. Final cleanup 

    Remove chirality test keyboard from main kmapro app
Fix KMSample2 compilation
    @darcywong00
    darcywong00 committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    0665756 View commit details
    Browse the repository at this point in the history