fix(web): font size was not consistently set #5906

mcdurdin · 2021-11-14T23:47:08Z

Fixes #5779.
Fixes #5731 (I believe mitigation is sufficient to close this issue).

A variety of interrelated font and font size display issues resolved:

KVK font was not applied early enough for size calculations, which meant that we were calculating font scaling per key based on a default font when transforming from the KVK data for desktop devices (defaultLayout.ts)
Font scaling for non-default layers was calculated when elements were not visible and had no size information, giving incorrect values. To resolve this, font scaling is now calculated when a layer is made visible, which had performance impacts; resolved by reducing unnecessary layer.refreshLayout() calls; see performance point 1 below (oskView.ts:layerChangeHandler())
getViewportScale() would return an incorrect scaled value when emulating touch devices on a desktop browser (kmwutils.ts)
After switching keyboards, the device-specific scaling factor was not maintained (oskView.ts:refreshLayout())

Related performance improvements:

Multiple calls to layer.refreshLayout() in refreshLayout() have been eliminated, and only the currently visible layer is now refreshed. This dramatically reduces the number of calls to getIdealFontSize() which was the primary concern of bug(web): getIdealFontSize is slow #5731. (visualKeyboards.ts)
Unnecessary use of innerHTML replaced with innerText (oskBaseKey.ts)

Minor Keyman Developer performance improvement:

The web debugger no longer recalculates the OSK twice (test.js)

User Testing

I am sorry that we need to run these tests across so many devices. However, there have been repeated issues with font scaling and there is special-case code for each platform, so we do need to do these tests.

SUITE_DEVELOPER: Test the web debugger in Keyman Developer

The web debugger in Developer currently runs only on desktop devices (see #5905). We need to test that the presentation of various Keyman keyboards is still working correctly here. You should not need to use Chrome Developer Tools to run these tests.

TEST_KHMER_ANGKOR: Test that the Khmer Angkor keyboard renders correctly in the web debugger in each of the available device views. Check multiple layers, not just the default layer.
TEST_OTHER_KEYBOARDS: Select a variety of keyboards - your choice - and verify that they display correctly in the web debugger. Note the keyboards that you test.

SUITE_COMPAT: Test that these changes are compatible across a range of devices

Here we want to check that KeymanWeb now displays the on screen keyboard correctly in a variety of contexts. For these groups, use KeymanWeb Unminified test page:

GROUP_WINDOWS_CHROME: KeymanWeb in Chrome on Windows
GROUP_WINDOWS_FIREFOX: Firefox on Windows
GROUP_MACOS_CHROME: Chrome on macOS
GROUP_LINUX_FIREFOX: Firefox on Linux
GROUP_IPAD_SAFARI: Safari on iPad (not Chrome emulation; iOS simulator okay)
GROUP_IPHONE_SAFARI: Safari on iPhone (not Chrome emulation; iOS simulator okay)
GROUP_ANDROIDPHONE_CHROME: Chrome on Android phone
GROUP_ANDROIDTABLET_CHROME: Chrome on Android tablet

The tests:

TEST_BASELINE: Check each of the keyboard in the unminified test page; make sure that different layers render correctly.
TEST_KHMER_ANGKOR: Load the Khmer Angkor keyboard by entering 'khmer_angkor' into the "Add a keyboard by keyboard name" field and clicking Add. Verify that it too displays correctly.
TEST_CHOICE: Choose a keyboard of your own liking to test -- this helps to verify that keyboards I haven't considered are also working correctly.

SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

For these groups, use the Keyman app on each device:

GROUP_IPAD_NATIVE: Keyman 15.0 on iPad (not Chrome emulation, but simulator okay)
GROUP_IPHONE_NATIVE: Keyman 15.0 on iPhone (not Chrome emulation, but simulator okay)
GROUP_ANDROIDPHONE_NATIVE: Keyman 15.0 on Android phone (not Chrome emulation, but simulator okay)
GROUP_ANDROIDTABLET_NATIVE: Keyman 15.0 on Android tablet (not Chrome emulation, but simulator okay)

The tests:

TEST_BASELINE: Check the SIL Euro Latin keyboard displays correctly
TEST_KHMER_ANGKOR: Install the Khmer Angkor keyboard. Verify that it too displays correctly.
TEST_CHOICE: Choose a keyboard of your own liking to test -- this helps to verify that keyboards I haven't considered are also working correctly.

Fixes #5779. Fixes #5731 (I believe mitigation is sufficient to close this issue). A variety of interrelated font and font size display issues resolved: 1. KVK font was not applied early enough for size calculations, which meant that we were calculating font scaling per key based on a default font when transforming from the KVK data for desktop devices (defaultLayout.ts) 2. Font scaling for non-default layers was calculated when elements were not visible and had no size information, giving incorrect values. To resolve this, font scaling is now calculated when a layer is made visible, which had performance impacts; resolved by reducing unnecessary `layer.refreshLayout()` calls; see performance point 1 below (oskView.ts:layerChangeHandler()) 3. `getViewportScale()` would return an incorrect scaled value when emulating touch devices on a desktop browser (kmwutils.ts) 4. After switching keyboards, the device-specific scaling factor was not maintained (oskView.ts:refreshLayout()) Related performance improvements: 1. Multiple calls to `layer.refreshLayout()` in `refreshLayout()` have been eliminated, and only the currently visible layer is now refreshed. This dramatically reduces the number of calls to `getIdealFontSize()` which was the primary concern of #5731. (visualKeyboards.ts) 2. Unnecessary use of `innerHTML` replaced with `innerText` (oskBaseKey.ts) Minor Keyman Developer performance improvement: 1. The web debugger no longer recalculates the OSK twice (test.js)

keymanapp-test-bot · 2021-11-14T23:47:12Z

User Test Results

Test specification and instructions

✅ SUITE_DEVELOPER: Test the web debugger in Keyman Developer

✅ TEST_KHMER_ANGKOR (PASSED): The letters on keycaps all look good and nothing is cropped off. (notes)
✅ TEST_OTHER_KEYBOARDS (PASSED): The letters on keycaps all look good and nothing is cropped off. But there is something I would like to report here while testing various keyboards. (notes)

✅ SUITE_COMPAT: Test that these changes are compatible across a range of devices

✅ GROUP_WINDOWS_CHROME: KeymanWeb in Chrome on Windows
- ✅ TEST_BASELINE (PASSED): Different layers of each keyboard in the test page are rendered correctly.
- ✅ TEST_KHMER_ANGKOR (PASSED): Nothing is too critical on each layer. (notes)
- ✅ TEST_CHOICE (PASSED): sil_myanmar_my3 keyboard is rendered correctly.
✅ GROUP_WINDOWS_FIREFOX: Firefox on Windows
- ✅ TEST_BASELINE (PASSED): Different layers of each keyboard in the test page are rendered correctly.
- ✅ TEST_KHMER_ANGKOR (PASSED): Nothing is too critical on each layer. (notes)
- ✅ TEST_CHOICE (PASSED): sil_myanmar_my3 keyboard is rendered correctly.
✅ GROUP_MACOS_CHROME: Chrome on macOS
- ✅ TEST_BASELINE (PASSED): Different layers of each keyboard in the test page are rendered correctly.
- ✅ TEST_KHMER_ANGKOR (PASSED): OK.
- ✅ TEST_CHOICE (PASSED): sil_myanmar_my3 keyboard is rendered correctly.
✅ GROUP_LINUX_FIREFOX: Firefox on Linux
- ✅ TEST_BASELINE (PASSED): Different layers of each keyboard in the test page are rendered correctly.
- ✅ TEST_KHMER_ANGKOR (PASSED): OK
- ✅ TEST_CHOICE (PASSED): sil_myanmar_my3 keyboard is rendered correctly.
✅ GROUP_IPAD_SAFARI: Safari on iPad (not Chrome emulation; iOS simulator okay)
- ✅ TEST_BASELINE (PASSED): OK
- ✅ TEST_KHMER_ANGKOR (PASSED): (note multiple dotted circles breaking scaling as a separate problem)
- ✅ TEST_CHOICE (PASSED): sil_myanmar_my3 keyboard is rendered correctly.
✅ GROUP_IPHONE_SAFARI: Safari on iPhone (not Chrome emulation; iOS simulator okay)
- ✅ TEST_BASELINE (PASSED): OK
- ✅ TEST_KHMER_ANGKOR (PASSED): (note multiple dotted circles breaking scaling as a separate problem)
- ✅ TEST_CHOICE (PASSED): sil_myanmar_my3 keyboard is rendered correctly.
✅ GROUP_ANDROIDPHONE_CHROME: Chrome on Android phone
- ✅ TEST_BASELINE (PASSED): the font size is now back to normal, not too big any longer. (notes)
- ✅ TEST_KHMER_ANGKOR (PASSED): the font size is now back to normal, not too big any longer. (notes)
- ✅ TEST_CHOICE (PASSED): the font size is now back to normal, not too big any longer. (notes)
✅ GROUP_ANDROIDTABLET_CHROME: Chrome on Android tablet
- ✅ TEST_BASELINE (PASSED): no issue
- ✅ TEST_KHMER_ANGKOR (PASSED): no issue
- ✅ TEST_CHOICE (PASSED): no issue (notes)

✅ SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

✅ GROUP_IPAD_NATIVE: Keyman 15.0 on iPad (not Chrome emulation, but simulator okay)
- ✅ TEST_BASELINE (PASSED): The EuroLatin keyboard displays correctly.
- ✅ TEST_KHMER_ANGKOR (PASSED): Khmer Angkor keyboard displays correctly. One thing with the two-character vowels though. They should be merged and nicely rendered as those on Android. (notes)
- ✅ TEST_CHOICE (PASSED): Myanmar3 (SIL) keyboard displays correctly.
✅ GROUP_IPHONE_NATIVE: Keyman 15.0 on iPhone (not Chrome emulation, but simulator okay)
- ✅ TEST_BASELINE (PASSED): The EuroLatin keyboard displays correctly.
- ✅ TEST_KHMER_ANGKOR (PASSED): (note multiple dotted circles breaking scaling as a separate problem)
- ✅ TEST_CHOICE (PASSED): Myanmar3 (SIL) keyboard displays correctly.
✅ GROUP_ANDROIDPHONE_NATIVE: Keyman 15.0 on Android phone (not Chrome emulation, but simulator okay)
- ✅ TEST_BASELINE (PASSED): The EuroLatin (SIL) keyboard displays correctly on all layers including the subkeys. (notes)
- ✅ TEST_KHMER_ANGKOR (PASSED): The OSK looks great. Nothing is cropped off or spilled over. (notes)
- ✅ TEST_CHOICE (PASSED): The OSK looks great. Nothing is cropped off or spilled over. (notes)
✅ GROUP_ANDROIDTABLET_NATIVE: Keyman 15.0 on Android tablet (not Chrome emulation, but simulator okay)
- ✅ TEST_BASELINE (PASSED): The EuroLatin (SIL) keyboard displays correctly.
- ✅ TEST_KHMER_ANGKOR (PASSED): Khmer Angkor displays correctly, but there is a separate issue (bug(android): three Khmer characters are not shown correctly on their keycaps #5986).
- ✅ TEST_CHOICE (PASSED): The Myanmar3 (SIL) keyboard displays correctly.

Test Artifacts

darcywong00

lgtm

MakaraSok · 2021-11-17T04:11:16Z

SUITE_DEVELOPER: Test the web debugger in Keyman Developer

TEST_KHMER_ANGKOR: PASSED The letters on keycaps all look good and nothing is cropped off.

One thing though that the OSK preview within Keyman Developer does not look great when it comes to two-character combination on a key. See below.
TEST_OTHER_KEYBOARDS: PASSED The letters on keycaps all look good and nothing is cropped off. But there is something I would like to report here while testing various keyboards.

The top part of subkeys is cropped off in iPhone and .
gff_amharic - iPhone

gff_amhaic - Samsung Galaxy S5

sil_euro_latin - iPhone

mcdurdin · 2021-11-17T05:57:47Z

One thing though that the OSK preview within Keyman Developer does not look great when it comes to two-character combination on a key. See below.

This is a font and renderer issue which is not trivial to solve. See for example how we fixed this for Lao: https://marc.durdin.net/2015/01/how-to-rendering-combining-marks-consistently-across-platforms-a-long-story/

mcdurdin · 2021-11-17T05:58:38Z

But there is something I would like to report here while testing various keyboards.
The top part of subkeys is cropped off in iPhone and [Android].

Tracking this in #5926.

MakaraSok · 2021-11-22T04:42:04Z

SUITE_COMPAT: Test that these changes are compatible across a range of devices

GROUP_WINDOWS_CHROME: KeymanWeb in Chrome on Windows
- TEST_BASELINE: PASSED Different layers of each keyboard in the test page are rendered correctly.
- TEST_KHMER_ANGKOR: PASSED Nothing is too critical on each layer.
  One thing with the Khmer Angkor where the dotted circles are not shown for three of all the diacritics.
- TEST_CHOICE: PASSED sil_myanmar_my3 keyboard is rendered correctly.
GROUP_WINDOWS_FIREFOX: Firefox on Windows
- TEST_BASELINE: PASSED Different layers of each keyboard in the test page are rendered correctly.
- TEST_KHMER_ANGKOR: PASSED Nothing is too critical on each layer.
  One thing though with this vowel ឿ. Its top part is not fully visible, on FireFox and Chrome on Windows and on FireFox on Linux.
  
  It looks OK on Chrome on macOS.
- TEST_CHOICE: PASSED sil_myanmar_my3 keyboard is rendered correctly.
GROUP_MACOS_CHROME: Chrome on macOS It looks like the texts on keycaps are bold which is different from those on Windows.
- TEST_BASELINE: PASSED Different layers of each keyboard in the test page are rendered correctly.
- TEST_KHMER_ANGKOR: PASSED OK.
- TEST_CHOICE: PASSED sil_myanmar_my3 keyboard is rendered correctly.
GROUP_LINUX_FIREFOX: Firefox on Linux
- TEST_BASELINE: PASSED Different layers of each keyboard in the test page are rendered correctly.
- TEST_KHMER_ANGKOR: PASSED OK
- TEST_CHOICE: PASSED sil_myanmar_my3 keyboard is rendered correctly.
GROUP_IPAD_SAFARI: Safari on iPad (not Chrome emulation; iOS simulator okay)
- TEST_BASELINE: PASSED OK
- TEST_KHMER_ANGKOR: FAILED Two keys on the shift layer are not fully visible. Also, the keycaps with two characters on them are not nicely merged as those on the computer.
- TEST_CHOICE: PASSED sil_myanmar_my3 keyboard is rendered correctly.
GROUP_IPHONE_SAFARI: Safari on iPhone (not Chrome emulation; iOS simulator okay)
- TEST_BASELINE: PASSED OK
- TEST_KHMER_ANGKOR: FAILED One of the subkeys on ោ is not fully visible. It's a two-character vowel, i.e. ោះ.
- TEST_CHOICE: PASSED sil_myanmar_my3 keyboard is rendered correctly.
GROUP_ANDROIDPHONE_CHROME: Chrome on Android phone
- TEST_BASELINE: FAILED The shift layer of Dzongkha keyboard has keys without two characters on the keycaps which are not rendered correctly. They look OK though on iOS.
- TEST_KHMER_ANGKOR: PASSED OK. Plus all two-character vowels are nicely rendered together.
- TEST_CHOICE: PASSED sil_myanmar_my3 keyboard is rendered correctly.
GROUP_ANDROIDTABLET_CHROME: Chrome on Android tablet
- TEST_BASELINE: FAILED Similar to the issue above for Dzongkha keyboard.
  
  Also, characters on keycaps are too small to see on the spacious keyboard layout. See the Lao characters below.
- TEST_KHMER_ANGKOR: PASSED It would be better though if each character on the keycaps are bigger. They look awkward to have big keycaps with small texts.
- TEST_CHOICE: PASSED It would be better though if each character on the keycaps are bigger. They look awkward to have big keycaps with small texts.

MakaraSok · 2021-11-23T07:38:00Z

SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

GROUP_IPAD_NATIVE: Keyman 15.0 on iPad (not Chrome emulation, but simulator okay)
- TEST_BASELINE: PASSED The EuroLatin keyboard displays correctly.
- TEST_KHMER_ANGKOR: PASSED Khmer Angkor keyboard displays correctly. One thing with the two-character vowels though. They should be merged and nicely rendered as those on Android.
- TEST_CHOICE: PASSED Myanmar3 (SIL) keyboard displays correctly.
GROUP_IPHONE_NATIVE: Keyman 15.0 on iPhone (not Chrome emulation, but simulator okay)
- TEST_BASELINE: PASSED The EuroLatin keyboard displays correctly.
- TEST_KHMER_ANGKOR: FAILED One of the subkeys on ោ is not fully visible. It's a two-character vowel, i.e. ោះ.
  
  It looks better on Android:
- TEST_CHOICE: PASSED Myanmar3 (SIL) keyboard displays correctly.
GROUP_ANDROIDPHONE_NATIVE: Keyman 15.0 on Android phone (not Chrome emulation, but simulator okay)
- TEST_BASELINE: PASSED The EuroLatin keyboard displays correctly.
- TEST_KHMER_ANGKOR: PASSED Khmer Angkor keyboard displays correctly. One thing is with the font of the text on subkeys. They seems to be different from that of the base keys'.
- TEST_CHOICE: PASSED Myanmar3 (SIL) keyboard displays correctly.
GROUP_ANDROIDTABLET_NATIVE: Keyman 15.0 on Android tablet (not Chrome emulation, but simulator okay)
- TEST_BASELINE: PASSED The EuroLatin keyboard displays correctly.
- TEST_KHMER_ANGKOR: PASSED Khmer Angkor keyboard displays correctly. One thing is with the font size of text on each key, they should be bigger.
- TEST_CHOICE: PASSED Myanmar3 (SIL) keyboard displays correctly. One thing is with the font size of text on each key, they should be bigger.

This makes two corrections: 1. Removed an obsolete test for screen size based on dpi, which is unreliable, meant that we had been treating many Android tablets as phones (domManager.ts). 2. Font scale for Android tablets had some incorrect assumptions around keyboard height and devicePixelRatio, which I was able to simplify into a fixed ratio, and was much better across all devices I tested (however, all emulated in Chrome).

mcdurdin · 2021-11-28T22:09:53Z

I have adjusted the font scaling for Android tablet devices. Can we retest Android devices?

The issues with scaling around specific two-part characters such as ោះ is a separate thing to resolve. This is really tricky. I have reviewed those tests where there are multiple dotted circles and PASSED them for this issue; feel free to open a new issue for us to track this as a general problem -- and as you noted the behaviour is different on each platform as well!

SUITE_COMPAT

GROUP_IPAD_SAFARI
- TEST_KHMER_ANGKOR: PASSED (note multiple dotted circles breaking scaling as a separate problem)
GROUP_IPHONE_SAFARI
- TEST_KHMER_ANGKOR: PASSED (note multiple dotted circles breaking scaling as a separate problem)
GROUP_ANDROIDPHONE_CHROME
- TEST_BASELINE: OPEN please retest
- TEST_KHMER_ANGKOR: OPEN please retest
- TEST_CHOICE: OPEN please retest
GROUP_ANDROIDTABLET_CHROME
- TEST_BASELINE: OPEN please retest
- TEST_KHMER_ANGKOR: OPEN please retest
- TEST_CHOICE: OPEN please retest

SUITE_APPS

GROUP_IPHONE_NATIVE
- TEST_KHMER_ANGKOR: PASSED (note multiple dotted circles breaking scaling as a separate problem)
GROUP_ANDROIDPHONE_NATIVE
- TEST_BASELINE: OPEN please retest
- TEST_KHMER_ANGKOR: OPEN please retest
- TEST_CHOICE: OPEN please retest
GROUP_ANDROIDTABLET_NATIVE
- TEST_BASELINE: OPEN please retest
- TEST_KHMER_ANGKOR: OPEN please retest
- TEST_CHOICE: OPEN please retest

MakaraSok · 2021-11-30T04:21:16Z

SUITE_COMPAT: Test that these changes are compatible across a range of devices

GROUP_ANDROIDPHONE_CHROME: Chrome on Android phone
- TEST_BASELINE: FAILED The character on each keycap become to big and for the Lao keyboard, some parts of some keys are cropped off or spilled over.
- TEST_KHMER_ANGKOR: FAILED The character on each keycap become to big and for the Lao keyboard, some parts of some keys are cropped off or spilled over.
- TEST_CHOICE: FAILED The character on each keycap become to big and for the Lao keyboard, some parts of some keys are cropped off or spilled over.
GROUP_ANDROIDTABLET_CHROME: Chrome on Android tablet
- TEST_BASELINE: PASSED Nothing is cropped off and the characters are visibly bigger, but the characters on keycaps are still not satisfactorily big enough comparing with the key size.
- TEST_KHMER_ANGKOR: PASSED The characters on keycaps are visibly bigger now.
- TEST_CHOICE: PASSED The characters on keycaps are visibly bigger now.

Note that on both Android phone and table, the shift layer of Dzongkha keyboard looks ugly.

MakaraSok · 2021-11-30T08:20:32Z

SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

GROUP_ANDROIDPHONE_NATIVE: Keyman 15.0 on Android phone (not Chrome emulation, but simulator okay)
- TEST_BASELINE: PASSED The EuroLatin (SIL) keyboard displays correctly on all layers including the subkeys.
- TEST_KHMER_ANGKOR: PASSED The OSK looks great. Nothing is cropped off or spilled over.
  
  But the font of the text on subkeys seems to be different from that of the base keys'.
- TEST_CHOICE: PASSED The OSK looks great. Nothing is cropped off or spilled over.
GROUP_ANDROIDTABLET_NATIVE: Keyman 15.0 on Android tablet (not Chrome emulation, but simulator okay)
- TEST_BASELINE: PASSED The EuroLatin (SIL) keyboard displays correctly.
- TEST_KHMER_ANGKOR: PASSED Khmer Angkor displays correctly, but there is a separate issue (bug(android): three Khmer characters are not shown correctly on their keycaps #5986).
- TEST_CHOICE: PASSED The Myanmar3 (SIL) keyboard displays correctly.

This is based on research from various websites, including Google documentation and https://screensiz.es/, as well as various older pages.

mcdurdin · 2021-12-02T04:40:26Z

Latest push should resolve the tablet detection, I hope. Please retest the relevant

SUITE_COMPAT
GROUP_ANDROIDPHONE_CHROME

TEST_BASELINE open please retest
TEST_KHMER_ANGKOR open please retest
TEST_CHOICE open please retest

GROUP_ANDROIDTABLET_CHROME

TEST_BASELINE open please retest
TEST_KHMER_ANGKOR open please retest
TEST_CHOICE open please retest

MakaraSok · 2021-12-06T12:00:22Z

SUITE_COMPAT
GROUP_ANDROIDPHONE_CHROME

TEST_BASELINE: PASSED the font size is now back to normal, not too big any longer.
TEST_KHMER_ANGKOR: PASSED the font size is now back to normal, not too big any longer.
TEST_CHOICE: PASSED the font size is now back to normal, not too big any longer.

Note that there is a weird behavior noted before and had been investigated with @darcywong00. I would like to show it here for our record.

Screen.Recording.2021-12-06.at.6.00.49.PM.mov

GROUP_ANDROIDTABLET_CHROME

TEST_BASELINE: PASSED no issue
TEST_KHMER_ANGKOR: PASSED no issue
TEST_CHOICE: PASSED no issue

One thing that stays the same is that the shift layer of Dzongkha keyboard is not shown correctly. No double dotted circle should be shown.

keyman-server · 2021-12-08T18:01:01Z

Changes in this pull request will be available for download in Keyman version 15.0.165-alpha

mcdurdin · 2021-12-22T22:59:39Z

See https://community.software.sil.org/t/feedback-on-keyman-15-0-alpha/5405/34 for details on regression introduced by this PR.

mcdurdin added this to the A15S18 milestone Nov 14, 2021

keymanapp-test-bot bot added the user-test-required User tests have not been completed label Nov 14, 2021

github-actions bot added common/ common/core/ common/web/ developer/ developer/ide/ web/ web/engine/ windows/ fix labels Nov 14, 2021

darcywong00 approved these changes Nov 15, 2021

View reviewed changes

mcdurdin mentioned this pull request Nov 17, 2021

bug(developer): new touch keyboard test window crops large longpress popups #5926

Closed

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 23, 2021

keymanapp-test-bot bot added the user-test-required User tests have not been completed label Nov 28, 2021

Merge branch 'master' into fix/web/5779-font-scaling-in-osk

e98930d

mcdurdin modified the milestones: A15S18, A15S19 Nov 29, 2021

MakaraSok mentioned this pull request Nov 30, 2021

bug(web/developer): different rendered texts on the keycaps of OSKs on KeymanWeb test page and web debugger in Developer #5983

Closed

MakaraSok mentioned this pull request Nov 30, 2021

bug(android): the base keys and the subkeys are in different font face #5985

Closed

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 30, 2021

fix(web): revise tablet detect strategy

9995c9f

This is based on research from various websites, including Google documentation and https://screensiz.es/, as well as various older pages.

keymanapp-test-bot bot added the user-test-required User tests have not been completed label Dec 2, 2021

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 6, 2021

mcdurdin mentioned this pull request Dec 7, 2021

bug(web): longpress touch position is sometimes wrong in landscape view #6017

Closed

mcdurdin merged commit 5ab9574 into master Dec 8, 2021

mcdurdin deleted the fix/web/5779-font-scaling-in-osk branch December 8, 2021 08:42

mcdurdin mentioned this pull request Dec 22, 2021

bug(web): font size is still wrong after #5906 #6076

Closed

mcdurdin added the has-user-test label Feb 12, 2022

mcdurdin mentioned this pull request Feb 19, 2022

bug(dzongkha): Dzongkha keyboard shows double dotted circle on shift layer on Android keymanapp/keyboards#1754

Open

mcdurdin mentioned this pull request Mar 4, 2022

feat(android/app): Improve UX for landscape orientation #2768

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): font size was not consistently set #5906

fix(web): font size was not consistently set #5906

mcdurdin commented Nov 14, 2021 •

edited

keymanapp-test-bot bot commented Nov 14, 2021 •

edited

darcywong00 left a comment

MakaraSok commented Nov 17, 2021

mcdurdin commented Nov 17, 2021

mcdurdin commented Nov 17, 2021

MakaraSok commented Nov 22, 2021 •

edited

MakaraSok commented Nov 23, 2021

mcdurdin commented Nov 28, 2021

MakaraSok commented Nov 30, 2021

MakaraSok commented Nov 30, 2021

mcdurdin commented Dec 2, 2021 •

edited

MakaraSok commented Dec 6, 2021

keyman-server commented Dec 8, 2021

mcdurdin commented Dec 22, 2021

fix(web): font size was not consistently set #5906

fix(web): font size was not consistently set #5906

Conversation

mcdurdin commented Nov 14, 2021 • edited

User Testing

SUITE_DEVELOPER: Test the web debugger in Keyman Developer

SUITE_COMPAT: Test that these changes are compatible across a range of devices

SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

keymanapp-test-bot bot commented Nov 14, 2021 • edited

User Test Results

✅ SUITE_DEVELOPER: Test the web debugger in Keyman Developer

✅ SUITE_COMPAT: Test that these changes are compatible across a range of devices

✅ SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

Test Artifacts

darcywong00 left a comment

Choose a reason for hiding this comment

MakaraSok commented Nov 17, 2021

SUITE_DEVELOPER: Test the web debugger in Keyman Developer

mcdurdin commented Nov 17, 2021

mcdurdin commented Nov 17, 2021

MakaraSok commented Nov 22, 2021 • edited

SUITE_COMPAT: Test that these changes are compatible across a range of devices

MakaraSok commented Nov 23, 2021

SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

mcdurdin commented Nov 28, 2021

MakaraSok commented Nov 30, 2021

SUITE_COMPAT: Test that these changes are compatible across a range of devices

MakaraSok commented Nov 30, 2021

SUITE_APPS: Test that these changes are compatible in Keyman apps on Android and iOS

mcdurdin commented Dec 2, 2021 • edited

MakaraSok commented Dec 6, 2021

keyman-server commented Dec 8, 2021

mcdurdin commented Dec 22, 2021

mcdurdin commented Nov 14, 2021 •

edited

keymanapp-test-bot bot commented Nov 14, 2021 •

edited

MakaraSok commented Nov 22, 2021 •

edited

mcdurdin commented Dec 2, 2021 •

edited