Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ability to use one key multiple times in sequence mode #513

Closed
getle87 opened this issue Nov 25, 2020 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request
Projects

Comments

@getle87
Copy link

getle87 commented Nov 25, 2020

Hello sds100,

currently I'm looking for a new app to replace the old Xposed Additions (development discontinued). Your app looks very promising for hardware key mapping tasks. There are many other key remapper apps in the store, but no one of them offers the ability to record own key sequences, but in your app this is possible. I only miss one function. Currently, each key can only be used once in recording a sequence trigger (e.g. Vol up + Vol down). Would it be possible to implement the function to use a key multiple times (e.g. Vol Up + Vol Down + Vol Up) to trigger an event? Can the timer (5s) then be reset until no new key is pressed?

current:
current

feature request (screenshot modified):
feature request

Sorry for my bad English, it's not my native language.

@sds100
Copy link
Collaborator

sds100 commented Nov 26, 2020

Hello,
I think I can add this but there will be one limitation. If you have a sequence trigger with multiple of the same key, all of those keys must have the same click type (short/long/double press).

E.g you couldn't have double press volume down + single press volume down but you could have double press volume down + double press volume down.

@sds100 sds100 self-assigned this Nov 26, 2020
@sds100 sds100 added the enhancement New feature or request label Nov 26, 2020
@sds100 sds100 added this to To do in 2.2.0 via automation Nov 26, 2020
@getle87
Copy link
Author

getle87 commented Nov 26, 2020

Hello,

thank you very much for your fast reply. I think this limitation should be no problem.

@sds100
Copy link
Collaborator

sds100 commented Nov 28, 2020

developer todo:

  • write tests
  • allow parallel triggers to have multiple keys with the same keycode but a different device
  • set the click types of all the keys with the same device id and keycode when setting the clicktype for a single key in that group

@sds100
Copy link
Collaborator

sds100 commented Nov 28, 2020

the limitation is now that you can have multiple of the same key from the same device as long as they have the same click type. This doesn't affect you but this is information for me.

@sds100
Copy link
Collaborator

sds100 commented Nov 28, 2020

implemented

@sds100 sds100 closed this as completed Nov 28, 2020
sds100 added a commit that referenced this issue Nov 28, 2020
2.2.0 automation moved this from To do to Done Nov 28, 2020
@getle87
Copy link
Author

getle87 commented Feb 10, 2021

Thank you, the new feature is great. I bought you some coffee on ko-fi.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
2.2.0
  
Done
Development

No branches or pull requests

2 participants