Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use viewbinding in fragments properly #518

Closed
sds100 opened this issue Dec 8, 2020 · 1 comment
Closed

use viewbinding in fragments properly #518

sds100 opened this issue Dec 8, 2020 · 1 comment
Assignees
@sds100
Labels
bug Something isn't working
Projects
2.2.0

Comments

@sds100
Copy link
Collaborator

sds100 commented Dec 8, 2020

https://developer.android.com/topic/libraries/view-binding#fragments
@sds100 sds100 added the bug Something isn't working label Dec 8, 2020
@sds100 sds100 self-assigned this Dec 8, 2020
@sds100 sds100 added this to To do in 2.2.0 via automation Dec 8, 2020
sds100 added a commit that referenced this issue Dec 10, 2020
@sds100
#518 RecyclerViewFragment: set binding field to null in onDestroyView
efc51b2 
limit the scope of the binding field to the view lifecycle
@sds100
Copy link
Collaborator Author

sds100 commented Dec 11, 2020

fixed

@sds100 sds100 closed this as completed Dec 11, 2020
2.2.0 automation moved this from To do to Done Dec 11, 2020
sds100 added a commit that referenced this issue Dec 11, 2020
@sds100
#518 create binding field in fragments and limit its scope between on…
c30d6f8 
…CreateView and onDestroyView

This will hopefully fix many of the crashes caused by using activity and navigation component methods at the wrong time in the lifecycle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sds100 sds100

Labels
bug Something isn't working
Projects
No open projects
2.2.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sds100