improv: opencensus mysql #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
suggested changes
Feb 13, 2019
vmarchaud
suggested changes
Feb 13, 2019
|
|
||
| if (this.internalFilesExports.Connection) { | ||
| this.logger.debug('patching mysql.Connection.createQuery') | ||
| shimmer.wrap(this.internalFilesExports.Connection, 'createQuery', this.getPatchCreateQuery()) |
There was a problem hiding this comment.
need to patch the prototype here too
There was a problem hiding this comment.
|
|
||
| /** Unpatches all Mysql patched functions. */ | ||
| applyUnpatch (): void { | ||
| shimmer.unwrap(this.internalFilesExports.Connection, 'createQuery') |
There was a problem hiding this comment.
and unwrap the prototype
src/census/plugins/mysql.ts
Outdated
| return function (...args: any[]) { | ||
| var span = plugin.tracer.startChildSpan('mysql-query', plugin.SPAN_MYSQL_QUERY_TYPE) | ||
| if (span === null) return original.apply(this, arguments) | ||
| var query = original.apply(this, arguments) |
| } | ||
| } | ||
|
|
||
| private getPatchGetConnection() { |
There was a problem hiding this comment.
should more something like this :
private getPatchGetConnection() {
const plugin = this
return (original: Function) => {
return function (cb: Function) {
return original.call(this, plugin.tracer.wrap(cb))
}
}
}
src/census/plugins/mysql.ts
Outdated
| private getPatchGetConnection() { | ||
| return (original: Function) => { | ||
| return function (...args: any[]) { | ||
| return original.call(this, this.tracer.wrap(arguments)) |
There was a problem hiding this comment.
the call to this.tracer will be undefined cause this refer to the function scope.
arguments will not work too cause .wrap accept function and not array
| @@ -0,0 +1,145 @@ | |||
| import { CoreTracer, RootSpan, SpanEventListener, logger } from '@pm2/opencensus-core' | |||
There was a problem hiding this comment.
need test for the connection pool patchs
There was a problem hiding this comment.
vmarchaud
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding mysql for oc tracing