Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future branch #7

Merged
merged 17 commits into from
Sep 27, 2022
Merged

Future branch #7

merged 17 commits into from
Sep 27, 2022

Conversation

keynmol
Copy link
Owner

@keynmol keynmol commented May 22, 2021

Plan is to have a future branch with:

  1. Cats effect 3
  2. Http4s 0.23
  3. Laminar 0.13.0
  4. Weaver 0.7.4
  5. sttp 3 http4s-dom 🎉
  6. Scala 3
  7. Slightly changed module structure
    • use projectmatrix
    • separate app and appDeploy modules
    • use resource generators to embed frontend JS

@keynmol
Copy link
Owner Author

keynmol commented Aug 19, 2021

At the moment this is blocked by an issue exactly the same as scala-js/scala-js-env-jsdom-nodejs#50 - the NPM infra is mutable, so stuff started breaking, presumably because I didn't put it in package-lock.json for Scala.js tests

@armanbilge
Copy link

Just saw this project, cool! Now that http4s 1.0-M24 is on Scala.js would you consider swapping it out for sttp? 😁

@keynmol
Copy link
Owner Author

keynmol commented Aug 23, 2021

I'd love to at least test it, sure :)

Would prefer to keep the branch on stable http4s lineage (0.23), tho.

Perhaps 1.0 will be released by the time I solve the NPM issue - which according to my calculations will just never happen, so we're safe

@armanbilge
Copy link

Btw, you are only testing with a single version of JSDOM right? Your problem is very fixable I think. See how we added a package lock in CE3 for example: typelevel/cats-effect#2191

@keynmol
Copy link
Owner Author

keynmol commented Aug 23, 2021

oh damn, I've been looking for a working package-lock.json, mine is corrupted! I will test yours and see if it works :)

@keynmol keynmol marked this pull request as ready for review September 27, 2022 09:10
@keynmol keynmol merged commit 1bfb584 into master Sep 27, 2022
@keynmol keynmol deleted the future branch September 27, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants