-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future branch #7
Conversation
At the moment this is blocked by an issue exactly the same as scala-js/scala-js-env-jsdom-nodejs#50 - the NPM infra is mutable, so stuff started breaking, presumably because I didn't put it in package-lock.json for Scala.js tests |
Just saw this project, cool! Now that http4s 1.0-M24 is on Scala.js would you consider swapping it out for sttp? 😁 |
I'd love to at least test it, sure :) Would prefer to keep the branch on stable http4s lineage (0.23), tho. Perhaps 1.0 will be released by the time I solve the NPM issue - which according to my calculations will just never happen, so we're safe |
Btw, you are only testing with a single version of JSDOM right? Your problem is very fixable I think. See how we added a package lock in CE3 for example: typelevel/cats-effect#2191 |
oh damn, I've been looking for a working package-lock.json, mine is corrupted! I will test yours and see if it works :) |
Plan is to have a
future
branch with:sttp 3http4s-dom 🎉appDeploy
modules