Minor bug fixes and code cleanup #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquynh
reviewed
Aug 28, 2017
| try: | ||
| from idc import GetOpType, GetOpnd, ItemEnd | ||
| except ImportError: | ||
| from idc_bc695 import GetOpType, GetOpnd, ItemEnd |
There was a problem hiding this comment.
As you are aware, there are major API changes between 32-bit IDA 6.x and 64-bit IDA 7.0. As a way to aid plugin porting, Hex-Rays has provided a backwards compatibility layer for some of the old APIs in 64-bit IDA 7.0. The idc_bc695 module provides these wrappers.
There was a problem hiding this comment.
Certainly the code which calls these functions could be refactored and wrapped in conditional statements, but this seemed to be the cleaner approach.
|
thanks for this cleanup! it looks good, except my comment on the idc_bd695. |
|
merged, thanks! |
fjh658
pushed a commit
to fjh658/keypatch
that referenced
this pull request
Sep 6, 2017
aquynh
pushed a commit
that referenced
this pull request
Sep 7, 2017
* fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Fixed inf has no attribute "mf" (#25) * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Minor bug fixes and code cleanup (#26) * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch
aquynh
pushed a commit
that referenced
this pull request
Oct 6, 2017
* fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Fixed inf has no attribute "mf" (#25) * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Minor bug fixes and code cleanup (#26) * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Update the installation documentation for the macOS ida * Improve the accuracy of the documentation
aquynh
pushed a commit
that referenced
this pull request
Dec 9, 2018
* fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Fixed inf has no attribute "mf" (#25) * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Minor bug fixes and code cleanup (#26) * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Update the installation documentation for the macOS ida * Improve the accuracy of the documentation * Fixed the form cannot be shown for ida pro 7.2 beta Version 7.2.181019. "form: error at %/"
aquynh
pushed a commit
that referenced
this pull request
Dec 11, 2018
…that analyzed 64 bit binary file about ida64 for win, and etc (#60) * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Fixed inf has no attribute "mf" (#25) * fixed inf no attribute "mf", because ida pro beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * fixed inf no attribute "mf", because ida pro7 beta 3 (170724) renamed inf.is_mf()/set_mf() -> is_be()/set_be() * Add ida pro version check, about be(big endian) * Since ida pro7 beta 3 (170724) renamed inf.mf -> is_be()/set_be(), Compatible with ida pro 6, 7(beta); for everyone is happy * Minor bug fixes and code cleanup (#26) * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * 1. fixed ida pro 7 beta6 x86 crash. idainfo object has no attribute 'procname' 2. refactor: removed "from idc_bc695" According to hexray log document, idc has been done on the adapter idc_bc695, do not need to expose idc_bc695. 3. refactor: removed the adapter idaapi.read_selection. idaapi.read_selection has been adapted internally * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Merge branch 'master' of https://github.com/fjh658/keypatch * Update the installation documentation for the macOS ida * Improve the accuracy of the documentation * Fixed the form cannot be shown for ida pro 7.2 beta Version 7.2.181019. "form: error at %/" * 1. Added debugging by pydevd 2. Added name with $, eg: jmp short $Done$ 3. Updated Author Date 2016->2018 4. Updated MAX_INSTRUCTION_STRLEN to 256 5. Fixed: the return value truncated(32 bit) of get_name_value function that analyzed 64 bit binary file about ida64 for win
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial thought here was to port keypatch to the IDA 7.0 beta, but happily I see that you've already started work on this front. Upon initially loading keypatch.py in PyCharm, several import errors and code quality issues were identified. I've changed calls to init so that they use super() instead of direct calls to superclass names, added missing / rearranged imports, qualified constants, fixed invalid references, removed dead code, etc.