Fixed the form cannot be shown for ida pro 7.2 release version

[fjh658]

Fixed the form(Patcher, Search, Fill Range) cannot be shown for ida pro 7.2 release version.

• The PR has been tested on ida6.x, ida7.0, 7.1, 7.2. @aquynh

Please see the picture below:

[fjh658]

Please review PR. @aquynh Thank you.

[aquynh]

sorry for very late reply!

this looks good, but please confirm that this works for v6.x

[aquynh]

also, would you mind verifying the pull req #36, to confirm it works for v7.x?

thanks!

[fjh658]

sorry for very late reply!

this looks good, but please confirm that this works for v6.x

It works that I tested for v6.x. @aquynh

[fjh658]

also, would you mind verifying the pull req #36, to confirm it works for v7.x?

thanks!

This pull req #36 is not recommended for merging, there are some problems.

1. idaapi.get_name_value(address, sym) -> idaapi.get_name_ea(address, sym)
   For jmp xxx case is good, but this will cause a lot of problems. b8b0f79
   eg:

• "Memory" variable
  

• idapython test

Python>ea = idaapi.get_name_ea(here(), "Memory")
Python>print(hex(ea))
0x140046aa8L

Error:

Python>(type, value) = idaapi.get_name_value(here(), "Memory")
Python>print(hex(value))
0xffffffffffffffe0L

Correct result:

In other words, the result of name is not ea will be incorrect.

About the current situation of this function get_name_value

2. The following code is not seen to have any problems, no need to modify. 36cdc94

# ask IDA to re-analyze the patched area
if orig_func_end == idc.BADADDR:
    # only analyze patched bytes, otherwise it would take a lot of time to re-analyze the whole binary
    idaapi.analyze_area(address, address + patched_len + 1)
else:
    idaapi.analyze_area(address, orig_func_end)

    # try to fix IDA function re-analyze issue after patching
    idaapi.func_setend(address, orig_func_end)

@aquynh

[aquynh]

merged, thanks!