Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Access-Control-Allow-Credentials header to cors middleware #4380

Open
mahnunchik opened this issue Jul 5, 2017 · 0 comments
Open

Add Access-Control-Allow-Credentials header to cors middleware #4380

mahnunchik opened this issue Jul 5, 2017 · 0 comments
Labels
help wanted security

Comments

@mahnunchik
Copy link
Contributor

Add Access-Control-Allow-Credentials header to cors middleware.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Credentials
ijmccallum added a commit to ijmccallum/keystone that referenced this issue Jun 3, 2018
@ijmccallum
Update cors.js
ec60828 
Add Access-Control-Allow-Credentials header to cors middleware keystonejs#4380
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Access-Control-Allow-Credentials

The only valid value for this header is true, so I've not added in a "keystone.get('cors allow credentials')" bit like in the 'methods' and 'headers' settings.

Hopefully that seems ok!
@ijmccallum ijmccallum mentioned this issue Jun 3, 2018
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stennie @mahnunchik