-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to multer 1.3.1 and automatically clean uploaded files #4704
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a3fcb46
Update to multer 1.3.1 and automatically clean uploaded files
JedWatson 1aaa9cd
Fix typo in bindBodyParser
JedWatson ed5d8bf
Add missing next() (thanks @ttsirkia!)
stennie 54c51c8
Merge branch 'master' into update-multer
dominikwilkowski 829c67a
Merge branch 'master' into update-multer
dominikwilkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
var fs = require('fs'); | ||
var multer = require('multer'); | ||
var os = require('os'); | ||
|
||
function handleUploadedFiles (req, res, next) { | ||
if (!req.files || !Array.isArray(req.files)) return; | ||
var originalFiles = req.files; | ||
var files = {}; | ||
originalFiles.forEach(function (i) { | ||
if (i.fieldname in files) { | ||
var tmp = files[i.fieldname]; | ||
files[i.fieldname] = [tmp]; | ||
} | ||
if (Array.isArray(files[i.fieldname])) { | ||
files[i.fieldname].push(i); | ||
} else { | ||
files[i.fieldname] = i; | ||
} | ||
}); | ||
req.files = files; | ||
var cleanup = function () { | ||
originalFiles.forEach(function (i) { | ||
if (i.path) { | ||
fs.unlink(i.path, function () {}); | ||
} | ||
}); | ||
}; | ||
res.on('close', cleanup); | ||
res.on('finish', cleanup); | ||
next(); | ||
}; | ||
|
||
exports.handleUploadedFiles = handleUploadedFiles; | ||
|
||
exports.configure = function (app, options) { | ||
var upload = multer(options || { | ||
dest: os.tmpdir(), | ||
}); | ||
app.use(upload.any()); | ||
app.use(handleUploadedFiles); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
return next();
?