Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with filename ext (ticket: #4765) #4960

Merged
merged 5 commits into from
Dec 17, 2019
Merged

Fix problem with filename ext (ticket: #4765) #4960

merged 5 commits into from
Dec 17, 2019

Conversation

scipe
Copy link
Contributor

@scipe scipe commented Aug 25, 2019

Hi guys. This is just fix for this ticket: keystonejs/keystone#4765

I am using keystone on 3 different servers and always I have this problem with saving files. This solution working everythere.

@laurenskling
Copy link
Contributor

@autoboxer @gautamsi , I've never used storage, can you take a look?

@scipe
Copy link
Contributor Author

scipe commented Sep 6, 2019

Hello guys @autoboxer @gautamsi. Any chance to check this PR on this / next week?

@gautamsi
Copy link
Member

I am fine with the changes

Copy link

@NeoTheSecond NeoTheSecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it work!

@scipe
Copy link
Contributor Author

scipe commented Sep 25, 2019

Up :)

@scipe
Copy link
Contributor Author

scipe commented Oct 19, 2019

Guys?

@scipe
Copy link
Contributor Author

scipe commented Nov 28, 2019

End of November

@scipe
Copy link
Contributor Author

scipe commented Dec 17, 2019

😢

@MadeByMike MadeByMike self-requested a review December 17, 2019 22:08
@MadeByMike MadeByMike closed this Dec 17, 2019
@MadeByMike MadeByMike reopened this Dec 17, 2019
@MadeByMike MadeByMike merged commit 0caf792 into keystonejs:master Dec 17, 2019
@scipe scipe deleted the fix/ticket4765 branch January 6, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants