More popover and filter dialog fixes (#5921)

* add dialog role and aria-modal attributes for better screen reader support

* woopsies

* changesets

* sort and column popover as well

* update changeset

* Update packages-next/keystone/src/___internal-do-not-use-will-break-in-patch/admin-ui/pages/ListPage/SortSelection.tsx

* copy change

* update copy

* more copy changes

.changeset/spicy-cows-drop.md

@@ -0,0 +1,5 @@
+---
+'@keystone-ui/popover': patch
+---
+
+Applied aria-modal and role=dialog to popover component for better screen reader support.

.changeset/tiny-walls-behave.md

@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Added more helpful aria-label and aria-description to filter, sort and column popover.

design-system/packages/popover/src/Popover.tsx

@@ -218,6 +218,8 @@ export const PopoverDialog = forwardRef<HTMLDivElement, DialogProps>(
     return (
       <Portal>
         <div
+          role="dialog"
+          aria-modal="true"
           ref={consumerRef}
           css={{
             background: colors.background,

packages-next/keystone/src/___internal-do-not-use-will-break-in-patch/admin-ui/pages/ListPage/FieldSelection.tsx

@@ -71,6 +71,8 @@ export function FieldSelection({
 
   return (
     <Popover
+      aria-label="Columns options"
+      aria-description={`list of column options to apply to the ${list.key} list`}
       triggerRenderer={({ triggerProps }) => {
         return (
           <Button weight="link" css={{ padding: 4 }} {...triggerProps}>

packages-next/keystone/src/___internal-do-not-use-will-break-in-patch/admin-ui/pages/ListPage/FilterAdd.tsx

@@ -74,7 +74,14 @@ export function FilterAdd({ listKey }: { listKey: string }) {
         </Box>
         <ChevronDownIcon size="small" />
       </Button>
-      <PopoverDialog arrow={arrow} isVisible={isOpen} {...dialog.props} ref={dialog.ref}>
+      <PopoverDialog
+        aria-label="Filters options"
+        aria-description={`list of filters to apply to the ${listKey} list`}
+        arrow={arrow}
+        isVisible={isOpen}
+        {...dialog.props}
+        ref={dialog.ref}
+      >
         {isOpen && (
           <FilterAddPopoverContent
             onClose={() => {

packages-next/keystone/src/___internal-do-not-use-will-break-in-patch/admin-ui/pages/ListPage/SortSelection.tsx

@@ -43,7 +43,14 @@ export function SortSelection({ list }: { list: ListMeta }) {
         </span>
       </Button>
 
-      <PopoverDialog arrow={arrow} isVisible={isOpen} {...dialog.props} ref={dialog.ref}>
+      <PopoverDialog
+        aria-label="Sort options"
+        aria-description={`list of sorting parameters to apply to the ${list.key} list`}
+        arrow={arrow}
+        isVisible={isOpen}
+        {...dialog.props}
+        ref={dialog.ref}
+      >
         {isOpen && (
           <SortSelectionPopoverContent
             onClose={() => {