Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a few issues with the Markdown field UI #2759

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Fixed a few issues with the Markdown field UI #2759

merged 2 commits into from
Apr 17, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Apr 16, 2020

  • Fixed the last line of the content being cut off
  • Fixed field descriptions not showing up
  • Fixed the editable area subtly biting into the container box border
  • Added a separator between the toolbar and the editable area
  • Tweaked padding and margins

Before:
image

After:
image

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2020 •
edited

🦋 Changeset is good to go

Latest commit: 472649d

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/fields-markdown Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Vultraz Vultraz force-pushed the markdown-field-interface-fix branch from 9eb769b to 6a6965a Compare April 16, 2020 11:52
timleslie
timleslie approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thanks!

@timleslie timleslie merged commit 3917509 into keystonejs:master Apr 17, 2020
@github-actions github-actions bot mentioned this pull request Apr 17, 2020
Merged
@Vultraz Vultraz deleted the markdown-field-interface-fix branch April 17, 2020 00:49
@github-actions github-actions bot mentioned this pull request Apr 17, 2020
Open
Wkasel pushed a commit to gosignal/keystone that referenced this pull request Apr 30, 2020
@Vultraz @Wkasel
Fixed a few issues with the Markdown field UI (keystonejs#2759)
8c967db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timleslie timleslie timleslie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vultraz @timleslie