Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to react-popper 2 #2786

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Migrated to react-popper 2 #2786

merged 2 commits into from
Apr 21, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Apr 20, 2020

Refactored to use the new hooks-based API. The only thing I couldn't test was the Content field alignment tooltip since I couldn't get the Add Block button to show up 馃

Also removed the react-popper and react-popper-tooltip deps from the fields package since those were unused there.

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2020

馃 Changeset is good to go

Latest commit: f8ee53c

We got this.

This PR includes changesets to release 3 packages
Name Type
@arch-ui/tooltip Patch
@keystonejs/field-content Patch
@keystonejs/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jossmac jossmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jossmac
Copy link
Member

jossmac commented Apr 20, 2020

[...]couldn't test the Content field alignment tooltip since I couldn't get the Add Block button to show up

@MadeByMike perhaps you could point @Vultraz in the right direction?

@timleslie timleslie merged commit 732128f into keystonejs:master Apr 21, 2020
@Vultraz Vultraz deleted the popper-2 branch April 21, 2020 00:52
This was referenced Apr 21, 2020
Wkasel pushed a commit to gosignal/keystone that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants