Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminUI doesn't confirm on 'cancel in item create #2822

Closed
ra-external opened this issue Apr 24, 2020 · 4 comments · Fixed by #3317
Closed

AdminUI doesn't confirm on 'cancel in item create #2822

ra-external opened this issue Apr 24, 2020 · 4 comments · Fixed by #3317

Comments

@ra-external
Copy link

When one is creating a new item, for example an 'Article', if one clicks on the 'create' button top right

image

and one fills out the item's fields and then clicks 'cancel' on the bottom

image

one does not receive a confirmation asking if one really wants to abandon editing. This causes all entered data to be lost.

What should happen is that you get a confirmation 'dialog' such as one gets when one deletes an item

image

In the meantime, is there any way I can implement the desired behavior?

@gautamsi
Copy link
Member

when you hit create again, you should have the date filled in already

@ra-external
Copy link
Author

Ok, that's good to know, but it's not very intuitive -- I would think a standard pop-up warning would be, well, standard...

@MadeByMike
Copy link
Contributor

Yep, seems reasonable. This is probably a good first issue if you'd like to have a crack at it @ra-external you are getting fairly familiar with the Admin UI. If not I'd say it's going to be a lower priority compared with other things on our list for a while.

@ra-external
Copy link
Author

@MadeByMike -- Thanks, when I can come up for air from the project I'm working on I'll take a look at it.

singhArmani added a commit that referenced this issue Jul 30, 2020
The form data inside the `createItemModal` was getting lost when user
hit the `cancel` button. This could lead to a bad UX.

This fix will identifies if form data has changed from its initial
values before closing the modal. If yes, then it alerts the user for
confirmation. Otherwise, will close the modal.

Closes: #2822
singhArmani added a commit that referenced this issue Jul 31, 2020
The form data inside the `createItemModal` was getting lost when user
hit the `cancel` button. This could lead to a bad UX.

This fix will identifies if form data has changed from its initial
values before closing the modal. If yes, then it alerts the user for
confirmation. Otherwise, will close the modal.

Closes: #2822
singhArmani added a commit that referenced this issue Jul 31, 2020
The form data inside the `createItemModal` was getting lost when user
hit the `cancel` button. This could lead to a bad UX.

This fix will identifies if form data has changed from its initial
values before closing the modal. If yes, then it alerts the user for
confirmation. Otherwise, will close the modal.

Closes: #2822

Add cypress test for confirmation modal
singhArmani added a commit that referenced this issue Aug 3, 2020
The form data inside the `createItemModal` was getting lost when user
hit the `cancel` button. This could lead to a bad UX.

This fix will identifies if form data has changed from its initial
values before closing the modal. If yes, then it alerts the user for
confirmation. Otherwise, will close the modal.

Closes: #2822

Add cypress test for confirmation modal
singhArmani added a commit that referenced this issue Aug 3, 2020
The form data inside the `createItemModal` was getting lost when user
hit the `cancel` button. This could lead to a bad UX.

This fix will identifies if form data has changed from its initial
values before closing the modal. If yes, then it alerts the user for
confirmation. Otherwise, will close the modal.

Closes: #2822

Add cypress test for confirmation modal
MadeByMike added a commit that referenced this issue Aug 4, 2020
The form data inside the `createItemModal` was getting lost when user
hit the `cancel` button. This could lead to a bad UX.

This fix will identifies if form data has changed from its initial
values before closing the modal. If yes, then it alerts the user for
confirmation. Otherwise, will close the modal.

Closes: #2822

Add cypress test for confirmation modal

Co-authored-by: Mike <mike@madebymike.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants