Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build AdminUI properly #2836

Closed
lucatk opened this issue Apr 26, 2020 · 4 comments
Closed

Can't build AdminUI properly #2836

lucatk opened this issue Apr 26, 2020 · 4 comments

Comments

@lucatk
Copy link

lucatk commented Apr 26, 2020

Bug report

Describe the bug

I'm trying to contribute to the project. I wanted to try out some changes on the admin-ui.
I've read the contributing guidelines.

To Reproduce

Steps to reproduce the behaviour. Please provide code snippets or a repository:

  1. git clone project
  2. Ran yarn
  3. Ran yarn in packages/app-admin-ui
  4. Made changes to app-admin-ui
  5. Ran yarn build
  6. Substituted @keystonejs/app-admin-ui package in my project for my local version (using yarn add PATH_TO_LOCAL_CLONE/packages/app-admin-ui
  7. Ran yarn start:dev, navigated to admin UI in browser
  8. See error

Expected behaviour

The admin UI to work.

Screenshots

System information

  • OS: macOS Catalina
  • Browser (if applies): Google Chrome 80.0.3987.163

Additional context

The build and KeystoneJS startup seems to work like normal (no errors)

@Vultraz
Copy link
Contributor

Vultraz commented Apr 27, 2020

The way I've been contributing is via running one of the demo projects. They're symlinked to the packages in /packages, so you can clone the monorepo and test out your changes that way.

  1. Clone repo and create your branch.
  2. Make changes directly to `packages/app-adminu-i/
  3. In root package.json, change the demo script to "demo": "yarn --cwd ./demo-projects", (needed because of yarn dev broken #2632 )
  4. Run yarn dev to launch the default demo (Todo List) to test your changes, or yarn demo $demoName dev to pick another.

@gautamsi
Copy link
Member

gautamsi commented Apr 27, 2020

@Vultraz you can use your own project inside keystone folder structure using a projects folder. see #1832

@Vultraz
Copy link
Contributor

Vultraz commented Apr 27, 2020

....huh! That I did not know. 😱

@MadeByMike
Copy link
Contributor

@lucatk this is likely because of the workspace configuration. There are ways around it but a better way would be to edit the admin-ui package directly on your own branch. Copy it somewhere if you'd like to reference the code. Also hit my up on the slack https://community.keystonejs.com/ if you'd like some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants