Consolidated #2427 and #2497 (functional components) #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 0c5a11d We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 29, 2020
|
Added |
|
Added |
|
merged #2910 affects refactor of AnimateHeight |
|
@tomasztunik resolved conflict 👍 |
jossmac
approved these changes
May 18, 2020
Vultraz
force-pushed
the
admin-ui-consolidate
branch
from
d555b74
to
0c5a11d
Compare
|
@Vultraz Sorry for the delay on this one, it's a bit more complex so I had Joss take a look, but it all looks good. And as I type this I see you've resolved the merge :-) |
|
@timleslie talk about timing 😂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated the two for easier review. The latter had some stuff (moving route props) that's now covered in #2827, and I figured out what to do with the nonexistent
innerRefin #2731. Should be good to go.