file-adapters - Removed unnecessary required fields for S3Adapter

[intmainvoid]

This PR implements the proposed solution for issue #2965 where an error was thrown if alternative AWS SDK authentication methods were used

[changeset-bot]

🦋 Changeset is good to go

Latest commit: be17452

We got this.

This PR includes changesets to release 6 packages

Name	Type
@keystonejs/file-adapters	Major
@keystonejs/demo-project-blog	Patch
@keystonejs/demo-project-meetup	Patch
@keystonejs/cypress-project-basic	Patch
@keystonejs/cypress-project-client-validation	Patch
@keystonejs/cypress-project-social-login	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Vultraz]

You'll need to add a changeset describing this change too.

[MadeByMike]

Moved accessKeyId, secretAccessKey and region to s3Options and renamed secretAccessKey to s3.

Previously:

const fileAdapter = new S3Adapter({
  bucket: 'bucket-name',
  accessKeyId: 'ACCESS_KEY_ID',
  secretAccessKey: 'SECRET_ACCESS_KEY',
  region: 'us-west-2',
});

now:

const fileAdapter = new S3Adapter({
  bucket: 'bucket-name',
  s3Options: {
    accessKeyId: 'ACCESS_KEY_ID',
    s3: 'SECRET_ACCESS_KEY',
    region: 'us-west-2',
  }
});

[intmainvoid]

A couple of things:

1/ The renaming of that property from secretAccessKey to s3 was an error in the docs. Fix forthcoming.

2/ Not sure about the accuracy of your description. These weren't "moved" anywhere. It's just that we stopped accepting them on the constructor. It was always possible (as it is after this change) to supply these properties via the s3Options parameter.

[timleslie]

I don't think we need to language lawyer the changeset too much, I think the examples do must of the heavy lifting to clarify exactly what has changed and what changes a developer would need to make in order to upgrade to the new package.

If we can make that update (or something sufficiently similar) then I'm happy to give this a ✅ and get it shipped 🚀

[intmainvoid]

Cool. I've made all the changes I think need to be done. Anything else specific we're waiting for?

[timleslie]

Just need to update the changeset to include the info from Mike's comment then we're good to go.

[intmainvoid]

Yep. I think this commit takes care of that. Have I missed something?

[timleslie]

Yep, the changeset file (.changeset/long-bags-itch.md) needs to contain the text that Mike suggested in this comment thread (or something similar). This is the text that will get put into the CHANGELOG file, and is the thing that developers will refer to when upgrading this major package version, so it's important that it clearly explains the before and after of this version change so that they can successfully this package.

[timleslie]

.

[timleslie]

This looks good now 👍 As one last thing before I merge could I get you to update your branch to master so that it can run against CI and once that goes green I'll merge the PR. Thanks!