Moved name config option from Keystone to Admin UI
#3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: ab42016 We got this. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Haha yep, this is exactly where I was going with the changes down in the adapter code. I'm just pondering the timing of this change, and whether we want to bundle it with this big batch of |
|
I think it makes sense to include with the others. It logically goes with the change to db names. |
timleslie
reviewed
Jul 5, 2020
packages/app-admin-ui/index.js
Outdated
| @@ -11,6 +11,7 @@ const getWebpackConfig = require('./server/getWebpackConfig'); | |||
|
|
|||
| class AdminUIApp { | |||
| constructor({ | |||
| name, | |||
There was a problem hiding this comment.
Can we default this to: name = 'Keystone'?
timleslie
suggested changes
Jul 5, 2020
|
@timleslie done |
Oops, on board, definitely not bored! 😅 |
Merged
This was referenced Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As says, since it's no longer used by the KS core and only passed to the Admin UI.