-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin UI static building #1088
Merged
Merged
Admin UI static building #1088
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
11e3121
Static build proof of concept
emmatown 5a87cbf
Merge branch 'master' into static-build-poc
emmatown af4b4a1
It's working but not ready yet
emmatown 6c39e5b
Get it actually working
emmatown 877a245
Get fallback routing working
emmatown a418559
Get static building with auth working
emmatown b859934
Try a thing for heroku
emmatown 796eeba
Add process.env.NODE_ENV = 'production' to build command
emmatown a102692
Try another thing
emmatown 98c488b
Try another thing
emmatown 07115bf
Try another thing
emmatown 6cb55ff
Try another thing
emmatown 6608677
Use mongo URI from env variable
emmatown 4e1da89
More stuff
emmatown 05699e5
Implement --out and distDir
emmatown d13bdb7
Merge branch 'master' into static-build-poc
emmatown 9247ae0
Deduplicate a util
emmatown cfe8dfc
Merge branch 'static-build-poc' of https://github.com/keystonejs/keys…
emmatown 501382a
Add changesets
emmatown d49e2ab
Merge branch 'master' into static-build-poc
emmatown 650c30b
Update packages/admin-ui/server/AdminUI.js
jesstelford a13f6c8
Stuff
emmatown 21f6208
Remove a thing
emmatown 8968ff7
Fix some stuff
emmatown e5a4847
Update packages/keystone/bin/commands/build.js
jesstelford 6c00031
Update docs to be accurate to what is currently implemented and make …
emmatown a24d5df
Prettier
emmatown de37634
Merge branch 'master' into static-build-poc
emmatown d3f31ad
Fix the cypress:run:ci script for the login tests
emmatown cf8a5bc
Update packages/keystone/bin/commands/dev.js
jesstelford 63197dd
Add DEFAULT_DIST_DIR
emmatown 1d7583a
Re-export DEFAULT_DIST_DIR to fix a bug
emmatown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{ "releases": [{ "name": "@keystone-alpha/keystone", "type": "minor" }], "dependents": [] } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- Add `build` and `start` commands |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"releases": [ | ||
{ "name": "@keystone-alpha/admin-ui", "type": "minor" }, | ||
{ "name": "@keystone-alpha/keystone", "type": "minor" }, | ||
{ "name": "@keystone-alpha/server", "type": "minor" }, | ||
{ "name": "@keystone-alpha/demo-project-blog", "type": "patch" }, | ||
{ "name": "@keystone-alpha/demo-project-meetup", "type": "patch" } | ||
], | ||
"dependents": [] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- Add Admin UI static building |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
web: yarn start:test | ||
web: cd demo-projects/blog && node node_modules/@keystone-alpha/keystone/bin/cli | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
const { DEFAULT_PORT, DEFAULT_ENTRY, DEFAULT_SERVER, prepare } = require('./lib/core'); | ||
const { | ||
DEFAULT_PORT, | ||
DEFAULT_ENTRY, | ||
DEFAULT_SERVER, | ||
DEFAULT_DIST_DIR, | ||
prepare, | ||
} = require('./lib/core'); | ||
|
||
module.exports = { DEFAULT_PORT, DEFAULT_ENTRY, DEFAULT_SERVER, prepare }; | ||
module.exports = { DEFAULT_PORT, DEFAULT_ENTRY, DEFAULT_SERVER, DEFAULT_DIST_DIR, prepare }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is strange, Heroku was being weird and this fixed it. I think it's only because of bolt monorepo reasons so it won't cause an issue for consumers