Noviny/use new changesets package #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR has a changeset ✅ Click here to learn what changesets are. |
emmatown
reviewed
May 6, 2019
There was a problem hiding this comment.
😍 😍 I'm so excited about the future of changesets.
I ran version-packages to see what the output looks like and there are some strange things. (see the comments)
# @keystone-alpha/admin-ui
## 3.2.0
### Minor Changes
- [22ec53a8](https://github.com/keystonejs/keystone-5/commit/22ec53a8):
- Adding support for custom pages in Admin UI
### Patch Changes
- [ebb858a5](https://github.com/keystonejs/keystone-5/commit/ebb858a5):
- Optimistically open Nested Create Item Modal and show loading spinner <!-- Why is there no empty line here? It makes it seems like the message is associated with the commit below when really it's related to the commit above -->
- [b8fc0a22](https://github.com/keystonejs/keystone-5/commit/b8fc0a22):
- Add tooltip to columns button in list table
- [81dc0be5](https://github.com/keystonejs/keystone-5/commit/81dc0be5):
- Update dependencies
- [119448fc](https://github.com/keystonejs/keystone-5/commit/119448fc):
- Field view Controllers: Rename `.getValue()` to `.serialize()` and add `.deserialize()` to enable handling pre-save to server & post-read from server respectively.
- [5e7d1940](https://github.com/keystonejs/keystone-5/commit/5e7d1940):
- Remove custom context menu on list page
- [c79cd7eb](https://github.com/keystonejs/keystone-5/commit/c79cd7eb):
- Update Many modal shows spinner while loading fields
- [c9102446](https://github.com/keystonejs/keystone-5/commit/c9102446):
- Add a mechanism for loading multiple Suspense-aware components in parallel
- [119448fc](https://github.com/keystonejs/keystone-5/commit/119448fc):
- Field view Controllers: Rename `.getIntialData()` to `.getDefaultValue()` to better reflect the purpose of the function.
- [997c0b9c](https://github.com/keystonejs/keystone-5/commit/997c0b9c): <!-- Why is this indented? -->
- DX: Open Create Modal optimistically and display loading state
- Updated dependencies [e6e95173](https://github.com/keystonejs/keystone-5/commit/e6e95173):
- Updated dependencies [81b481d0](https://github.com/keystonejs/keystone-5/commit/81b481d0):
- Updated dependencies [a03fd601](https://github.com/keystonejs/keystone-5/commit/a03fd601):
- Updated dependencies [5f1a5cf3](https://github.com/keystonejs/keystone-5/commit/5f1a5cf3):
- Updated dependencies [1a7b706c](https://github.com/keystonejs/keystone-5/commit/1a7b706c):
- Updated dependencies [1a7b706c](https://github.com/keystonejs/keystone-5/commit/1a7b706c):
- Updated dependencies [bd0ea21f](https://github.com/keystonejs/keystone-5/commit/bd0ea21f):
- Updated dependencies [b7a2ea9c](https://github.com/keystonejs/keystone-5/commit/b7a2ea9c):
- Updated dependencies [5f1a5cf3](https://github.com/keystonejs/keystone-5/commit/5f1a5cf3):
- @keystone-alpha/fields@6.0.0
- @keystone-alpha/build-field-types@1.0.0
- @arch-ui/controls@0.0.5
- @arch-ui/input@0.0.5
- @arch-ui/confirm@0.0.6
- @arch-ui/dialog@0.0.6
- @arch-ui/drawer@0.0.6
- @arch-ui/dropdown@0.0.6
- @arch-ui/tooltip@0.0.6
- @arch-ui/popout@0.0.6
- @keystone-alpha/utils@3.0.0
|
Missed the strategy you were using to write changesets a little bit. Moved it back towards what it was, which produces the following. (more comments after the block) There's a new strategy which combines the first two lines of what you have together like: but I'd still like to condense it down to: as the second LB seems like it will add a lot of random padding to changelogs. Oh. Except prettier refuses to allow it 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out with the old and in with the new! 🦋
I've made the one change that requires a manual update from the user (new changelog format means updating the changelog lines, otherwise things should Just Work (🙏).
I have left all the commands in the
package.jsonthe same, simply made them call the new scripts.