Simplify Content Type setup to extend Relationship #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR has a changeset ✅ Click here to learn what changesets are. |
jesstelford
force-pushed
the
refactor-content-type
branch
from
c1e4fa3
to
6a9d4ab
Compare
jesstelford
commented
May 7, 2019
| ...RelationshipType, | ||
| implementation: class extends RelationshipType.implementation { | ||
| async resolveNestedOperations(operations, item, context, ...args) { | ||
| const result = await super.resolveNestedOperations(operations, item, context, ...args); |
There was a problem hiding this comment.
Taking advantage of work from https://github.com/keystonejs/keystone-5/pull/1033
emmatown
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was struck with inspiration 🛰💥, and realised that the
Contenttype should extend theRelationshiptype (instead ofText), which means all the tricky stuff I was trying to do with manually triggering nested mutations can be handled by KS5 like normal.This also greatly simplifies the next bit of work which is querying for the data, plus enables the
fromback-linkRelationshipto work out of the box.