Move Admin UI session middleware registering to Admin UI internals #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR has a changeset ✅ Click here to learn what changesets are. |
|
Closing because the session stuff will change and this is intentionally out of place for now. |
timleslie
deleted the
move-admin-ui-session-middleware-to-admin-ui-internals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on the "servers" thing and noticed that the Admin UI session middleware registering happened outside of admin UI internals for no reason(i think) and that won't work with the encapsulation that servers will have.
I've added a changeset with major bumps since using the current version of
@keystone-alpha/serverand a version of@keystone-alpha/admin-uiwith this change or vice versa would break things.