Fix regression when parent list of a Content field had a where clau…
#1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se as its access control.
🦋 Changeset is good to goLatest commit: 5275bff We got this. Not sure what this means? Click here to learn what changesets are. |
MadeByMike
reviewed
Sep 18, 2019
| @@ -51,7 +51,16 @@ export class OEmbedBlock extends Block { | |||
| 'A reference back to the Slate.js Serialised Document this embed is contained within', | |||
| }, | |||
| }, | |||
| access: listConfig.listAccess, | |||
| access: Object.entries(listConfig.listAccess).reduce( | |||
There was a problem hiding this comment.
Yeah, maybe, but also I don't have time right now :-)
There was a problem hiding this comment.
The real refactor should come one level higher with the way we create these Aux lists for blocks, but that's future Tim's problem.
MadeByMike
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…se as its access control.