Add docs for Docker-based KS deployments #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added a placeholder section for explaining the keystone build/start commands, etc. https://github.com/keystonejs/keystone-5/issues/1266 https://github.com/keystonejs/keystone-5/issues/1257
💥 No ChangesetLatest commit: b92109f Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. |
|
Should we not have separate Dockerfile? |
Sorry, I don't know what you mean. Are you suggesting another kind of Dockerfile? |
jesstelford
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a placeholder section for explaining the keystone build/start
commands, etc.
https://github.com/keystonejs/keystone-5/issues/1266
https://github.com/keystonejs/keystone-5/issues/1257
@MadeByMike I'm not sure about Keystone's deployment "style" (e.g., recommended
yarnusage or whatever), so the docs might need some tweaks.